[infra] Patch submitters can remove core reviewer votes?
See https://review.openstack.org/#/c/637703/
I'm assuming in that case it was an accident, but it doesn't seem like this should be possible at all. For example, if I had -2'd would it still have allowed the removal? Maybe you can only remove positive votes?
Anyway, seemed weird to me so I thought I would bring it up.
-Ben
On 2019-02-19 10:03:39 -0600 (-0600), Ben Nemec wrote:
See https://review.openstack.org/#/c/637703/
I'm assuming in that case it was an accident, but it doesn't seem like this should be possible at all. For example, if I had -2'd would it still have allowed the removal? Maybe you can only remove positive votes?
The latter, yes:
https://review.openstack.org/Documentation/access-control.html#category_remo...
Anyway, seemed weird to me so I thought I would bring it up.
Thanks for doing so. It's a sometimes surprising behavior worth keeping in mind!
On 2/19/19 10:13 AM, Jeremy Stanley wrote:
On 2019-02-19 10:03:39 -0600 (-0600), Ben Nemec wrote:
See https://review.openstack.org/#/c/637703/
I'm assuming in that case it was an accident, but it doesn't seem like this should be possible at all. For example, if I had -2'd would it still have allowed the removal? Maybe you can only remove positive votes?
The latter, yes:
https://review.openstack.org/Documentation/access-control.html#category_remo...
Anyway, seemed weird to me so I thought I would bring it up.
Thanks for doing so. It's a sometimes surprising behavior worth keeping in mind!
Yeah, definitely made me o.O when I saw it. :-)
Thanks!
On Tue, Feb 19, 2019, at 8:03 AM, Ben Nemec wrote:
See https://review.openstack.org/#/c/637703/
I'm assuming in that case it was an accident, but it doesn't seem like this should be possible at all. For example, if I had -2'd would it still have allowed the removal? Maybe you can only remove positive votes?
Anyway, seemed weird to me so I thought I would bring it up.
I want to say we tested this as a behavior noticed during upgrade prep a year and a half ago. And as you suspect it is only allowed for positive votes. However, you should double check us on that. Can you see if you are able to remove either of the -1's on https://review.openstack.org/#/c/571321/ ? (you own that change so should be a reasonable reproduction case).
I'd do it myself but unfortunately my account (and other Gerrit admin accounts) can always do this for reasons...
Clark
On 2/19/19 10:13 AM, Clark Boylan wrote:
On Tue, Feb 19, 2019, at 8:03 AM, Ben Nemec wrote:
See https://review.openstack.org/#/c/637703/
I'm assuming in that case it was an accident, but it doesn't seem like this should be possible at all. For example, if I had -2'd would it still have allowed the removal? Maybe you can only remove positive votes?
Anyway, seemed weird to me so I thought I would bring it up.
I want to say we tested this as a behavior noticed during upgrade prep a year and a half ago. And as you suspect it is only allowed for positive votes. However, you should double check us on that. Can you see if you are able to remove either of the -1's on https://review.openstack.org/#/c/571321/ ? (you own that change so should be a reasonable reproduction case).
No, I can't, so looks like this is working as intended. Thanks!
I'd do it myself but unfortunately my account (and other Gerrit admin accounts) can always do this for reasons...
Clark
participants (3)
-
Ben Nemec
-
Clark Boylan
-
Jeremy Stanley