[designate][heat][horizon][ironic][magnum][octavia][searchlight][senlin][vitrage][zaqar][zun] Upgrading nodejs version
Hey all! NodeJS version 4 isn't a supported version anymore - and what's more there are no packages for it for bionic. To that end, all of the UI projects that are currently requesting node_version: 4 in their npm jobs [0] or who are using any of the templates that start with nodejs4- [1] are about to have a large amount of sad. I would personally recommend updating to node_version: 10 - since that's the most recent LTS and would give us until 2021-04-01 [2] before we need to deal with things again. BUT - I don't have a real opinion on course of action - I figure that's likely something to be discussed amongst the various UI projects. The only thing I have an opinion on is that the outcome probably shouldn't be "shrug, nodejs4 is fine". :) Monty [0] http://codesearch.openstack.org/?q=node_version%3A%204&i=nope&files=&repos= [1] http://codesearch.openstack.org/?q=nodejs4&i=nope&files=&repos= [2] https://nodejs.org/en/about/releases/
On 13/03/2019 22:57, Monty Taylor wrote:
Hey all!
NodeJS version 4 isn't a supported version anymore - and what's more there are no packages for it for bionic.
To that end, all of the UI projects that are currently requesting node_version: 4 in their npm jobs [0] or who are using any of the templates that start with nodejs4- [1] are about to have a large amount of sad.
I would personally recommend updating to node_version: 10 - since that's the most recent LTS and would give us until 2021-04-01 [2] before we need to deal with things again.
BUT - I don't have a real opinion on course of action - I figure that's likely something to be discussed amongst the various UI projects. The only thing I have an opinion on is that the outcome probably shouldn't be "shrug, nodejs4 is fine". :)
Yeah - that sounds like something we should upgrade. Is there any preferred way the horizon team has for us to update this? Any known pitfalls? I am honestly not sure what will happen if we go from 4 -> 10 (and for most of our team the horizon plugin is a blackbox), so this is a trip into the unknown :/
Monty
[0] http://codesearch.openstack.org/?q=node_version%3A%204&i=nope&files=&repos= [1] http://codesearch.openstack.org/?q=nodejs4&i=nope&files=&repos= [2] https://nodejs.org/en/about/releases/
On 3/13/19 11:14 PM, Graham Hayes wrote:
On 13/03/2019 22:57, Monty Taylor wrote:
Hey all!
NodeJS version 4 isn't a supported version anymore - and what's more there are no packages for it for bionic.
To that end, all of the UI projects that are currently requesting node_version: 4 in their npm jobs [0] or who are using any of the templates that start with nodejs4- [1] are about to have a large amount of sad.
I would personally recommend updating to node_version: 10 - since that's the most recent LTS and would give us until 2021-04-01 [2] before we need to deal with things again.
BUT - I don't have a real opinion on course of action - I figure that's likely something to be discussed amongst the various UI projects. The only thing I have an opinion on is that the outcome probably shouldn't be "shrug, nodejs4 is fine". :)
Yeah - that sounds like something we should upgrade. Is there any preferred way the horizon team has for us to update this? Any known pitfalls?
I am honestly not sure what will happen if we go from 4 -> 10 (and for most of our team the horizon plugin is a blackbox), so this is a trip into the unknown :/
Yeah - I have no clue how complex it's going to be. :) For now, we landed a patch to openstack-zuul-jobs to update the nodejs4- project-templates to run on xenial, so that we don't have to rush. https://review.openstack.org/643182 I think it's probably a good idea for folks with node_version: 4 in their zuul.yaml files to add a xenial nodeset. That should unbreak anyone having issues - and we can figure out how to fix this during train. Monty
On Thu, Mar 14, 2019 at 8:15 AM Graham Hayes <gr@ham.ie> wrote:
On 13/03/2019 22:57, Monty Taylor wrote:
Hey all!
NodeJS version 4 isn't a supported version anymore - and what's more there are no packages for it for bionic.
To that end, all of the UI projects that are currently requesting node_version: 4 in their npm jobs [0] or who are using any of the templates that start with nodejs4- [1] are about to have a large amount of sad.
I would personally recommend updating to node_version: 10 - since that's the most recent LTS and would give us until 2021-04-01 [2] before we need to deal with things again.
BUT - I don't have a real opinion on course of action - I figure that's likely something to be discussed amongst the various UI projects. The only thing I have an opinion on is that the outcome probably shouldn't be "shrug, nodejs4 is fine". :)
Yeah - that sounds like something we should upgrade. Is there any preferred way the horizon team has for us to update this? Any known pitfalls?
I am honestly not sure what will happen if we go from 4 -> 10 (and for most of our team the horizon plugin is a blackbox), so this is a trip into the unknown :/
Yeah, we should upgrade nodejs considering its lifecycle. Unfortunately, the horizon team have not been aware of this so far.... We need to migrate nodejs jobs to bionic at the early phase of Train. All folks who set up JavaScript stuffs have gone and we need volunteers. I added this to the horizon PTG topics. Akihiro
Monty
[0]
http://codesearch.openstack.org/?q=node_version%3A%204&i=nope&files=&repos=
[1] http://codesearch.openstack.org/?q=nodejs4&i=nope&files=&repos= [2] https://nodejs.org/en/about/releases/
On 14/03/2019 07:00, Akihiro Motoki wrote:
On Thu, Mar 14, 2019 at 8:15 AM Graham Hayes <gr@ham.ie <mailto:gr@ham.ie>> wrote:
On 13/03/2019 22:57, Monty Taylor wrote: > Hey all! > > NodeJS version 4 isn't a supported version anymore - and what's more > there are no packages for it for bionic. > > To that end, all of the UI projects that are currently requesting > node_version: 4 in their npm jobs [0] or who are using any of the > templates that start with nodejs4- [1] are about to have a large amount > of sad. > > I would personally recommend updating to node_version: 10 - since that's > the most recent LTS and would give us until 2021-04-01 [2] before we > need to deal with things again. > > BUT - I don't have a real opinion on course of action - I figure that's > likely something to be discussed amongst the various UI projects. The > only thing I have an opinion on is that the outcome probably shouldn't > be "shrug, nodejs4 is fine". :)
Yeah - that sounds like something we should upgrade. Is there any preferred way the horizon team has for us to update this? Any known pitfalls?
I am honestly not sure what will happen if we go from 4 -> 10 (and for most of our team the horizon plugin is a blackbox), so this is a trip into the unknown :/
Yeah, we should upgrade nodejs considering its lifecycle. Unfortunately, the horizon team have not been aware of this so far.... We need to migrate nodejs jobs to bionic at the early phase of Train. All folks who set up JavaScript stuffs have gone and we need volunteers. I added this to the horizon PTG topics.
Akihiro
In https://review.openstack.org/642272 I raised the topic of adding node versions to the PTI for each cycle - some input from horizon folks, or anyone how knows about node is welcome :) - Graham
> Monty > > [0] > http://codesearch.openstack.org/?q=node_version%3A%204&i=nope&files=&repos= > [1] http://codesearch.openstack.org/?q=nodejs4&i=nope&files=&repos= > [2] https://nodejs.org/en/about/releases/ >
Hi team, That's what I have somewhere in my action list to take a look in the future. I just checked only Horizon and several plugins: Heat, Vitrage, and Ironic. I'm pretty sure that we've got the same situation for other plugins too. We use NodeJS only for tests and linting now. 'tox -e npm' installs NodeJS v11.11.0 on my laptop. This means that it should be safe to change NodeJS version on gates to use v10 and Bionic. Anyway, I propose to do it per project and fix any possible issues once Train development started. Regards, Ivan Kolodyazhny, http://blog.e0ne.info/ On Thu, Mar 14, 2019 at 2:30 PM Graham Hayes <gr@ham.ie> wrote:
On 14/03/2019 07:00, Akihiro Motoki wrote:
On Thu, Mar 14, 2019 at 8:15 AM Graham Hayes <gr@ham.ie <mailto:gr@ham.ie>> wrote:
On 13/03/2019 22:57, Monty Taylor wrote: > Hey all! > > NodeJS version 4 isn't a supported version anymore - and what's
more
> there are no packages for it for bionic. > > To that end, all of the UI projects that are currently requesting > node_version: 4 in their npm jobs [0] or who are using any of the > templates that start with nodejs4- [1] are about to have a large amount > of sad. > > I would personally recommend updating to node_version: 10 - since that's > the most recent LTS and would give us until 2021-04-01 [2] before
we
> need to deal with things again. > > BUT - I don't have a real opinion on course of action - I figure that's > likely something to be discussed amongst the various UI projects.
The
> only thing I have an opinion on is that the outcome probably
shouldn't
> be "shrug, nodejs4 is fine". :)
Yeah - that sounds like something we should upgrade. Is there any preferred way the horizon team has for us to update this? Any known pitfalls?
I am honestly not sure what will happen if we go from 4 -> 10 (and for most of our team the horizon plugin is a blackbox), so this is a trip into the unknown :/
Yeah, we should upgrade nodejs considering its lifecycle. Unfortunately, the horizon team have not been aware of this so far.... We need to migrate nodejs jobs to bionic at the early phase of Train. All folks who set up JavaScript stuffs have gone and we need volunteers. I added this to the horizon PTG topics.
Akihiro
In https://review.openstack.org/642272 I raised the topic of adding node versions to the PTI for each cycle - some input from horizon folks, or anyone how knows about node is welcome :)
- Graham
> Monty > > [0] >
http://codesearch.openstack.org/?q=node_version%3A%204&i=nope&files=&repos=
> [1]
http://codesearch.openstack.org/?q=nodejs4&i=nope&files=&repos=
On 14/03/2019 21:39, Ivan Kolodyazhny wrote:
Hi team,
That's what I have somewhere in my action list to take a look in the future.
I just checked only Horizon and several plugins: Heat, Vitrage, and Ironic. I'm pretty sure that we've got the same situation for other plugins too.
We use NodeJS only for tests and linting now. 'tox -e npm' installs NodeJS v11.11.0 on my laptop. This means that it should be safe to change NodeJS version on gates to use v10 and Bionic.
Anyway, I propose to do it per project and fix any possible issues once Train development started.
Regards, Ivan Kolodyazhny, http://blog.e0ne.info/
I proposed https://review.openstack.org/#/c/643603 to decide the train runtimes - if someone with JS + OpenStack knowledge, could comment and let us know if we are on the right track, that would be great. Thanks - Graham
On Thu, Mar 14, 2019 at 2:30 PM Graham Hayes <gr@ham.ie <mailto:gr@ham.ie>> wrote:
On 14/03/2019 07:00, Akihiro Motoki wrote: > > On Thu, Mar 14, 2019 at 8:15 AM Graham Hayes <gr@ham.ie <mailto:gr@ham.ie> > <mailto:gr@ham.ie <mailto:gr@ham.ie>>> wrote: > > > > On 13/03/2019 22:57, Monty Taylor wrote: > > Hey all! > > > > NodeJS version 4 isn't a supported version anymore - and what's more > > there are no packages for it for bionic. > > > > To that end, all of the UI projects that are currently requesting > > node_version: 4 in their npm jobs [0] or who are using any of the > > templates that start with nodejs4- [1] are about to have a large > amount > > of sad. > > > > I would personally recommend updating to node_version: 10 - since > that's > > the most recent LTS and would give us until 2021-04-01 [2] before we > > need to deal with things again. > > > > BUT - I don't have a real opinion on course of action - I figure > that's > > likely something to be discussed amongst the various UI projects. The > > only thing I have an opinion on is that the outcome probably shouldn't > > be "shrug, nodejs4 is fine". :) > > Yeah - that sounds like something we should upgrade. Is there any > preferred way the horizon team has for us to update this? Any > known pitfalls? > > I am honestly not sure what will happen if we go from 4 -> 10 > (and for most of our team the horizon plugin is a blackbox), > so this is a trip into the unknown :/ > > > Yeah, we should upgrade nodejs considering its lifecycle. > Unfortunately, the horizon team have not been aware of this so far.... > We need to migrate nodejs jobs to bionic at the early phase of Train. > All folks who set up JavaScript stuffs have gone and we need volunteers. > I added this to the horizon PTG topics. > > Akihiro
In https://review.openstack.org/642272 I raised the topic of adding node versions to the PTI for each cycle - some input from horizon folks, or anyone how knows about node is welcome :)
- Graham
> > > > > Monty > > > > [0] > > > http://codesearch.openstack.org/?q=node_version%3A%204&i=nope&files=&repos= > > [1] http://codesearch.openstack.org/?q=nodejs4&i=nope&files=&repos= > > [2] https://nodejs.org/en/about/releases/ > > >
On Mar 13, 2019, at 6:57 PM, Monty Taylor <mordred@inaugust.com> wrote:
Hey all!
NodeJS version 4 isn't a supported version anymore - and what's more there are no packages for it for bionic.
To that end, all of the UI projects that are currently requesting node_version: 4 in their npm jobs [0] or who are using any of the templates that start with nodejs4- [1] are about to have a large amount of sad.
I would personally recommend updating to node_version: 10 - since that's the most recent LTS and would give us until 2021-04-01 [2] before we need to deal with things again.
BUT - I don't have a real opinion on course of action - I figure that's likely something to be discussed amongst the various UI projects. The only thing I have an opinion on is that the outcome probably shouldn't be "shrug, nodejs4 is fine". :)
Monty
[0] http://codesearch.openstack.org/?q=node_version%3A%204&i=nope&files=&repos= [1] http://codesearch.openstack.org/?q=nodejs4&i=nope&files=&repos= [2] https://nodejs.org/en/about/releases/
It sounds like the TC needs to add node to the per-cycle tested platform list, like we have done for python and golang. Someone please propose the update to the governance site when you decide which version to use. Doug
participants (5)
-
Akihiro Motoki
-
Doug Hellmann
-
Graham Hayes
-
Ivan Kolodyazhny
-
Monty Taylor