Moving ara code review to GitHub
Hi openstack-discuss, long time no see o/ I've long dreaded doing this and sending this email out because I know how the community feels about proprietary platforms and I value the four opens that the OpenStack community has taught me so much about. I've recently reached out and asked if people would be more likely to contribute to ara if pull requests were possible [1] and had a number of potential contributors interested. Don't get me wrong: I still like OpenStack (have a cloud in my basement!) and personally prefer the Gerrit change workflow to the one on GitHub. However, I've come to the conclusion that my personal preferences should not be a barrier to contribution and so for the health and sustainability of the project I'll move the code review for ara to GitHub leveraging Ansible's Zuul deployment [2] for CI. The truth is that ara never had many contributors and the few that were interested were often discouraged by the process involved in signing up and sending a change through Gerrit. It broke my heart to see a pull request being automatically closed with a template by an OpenStack bot. It broke my heart to have to tell people that they must jump through several hoops to send a patch. I was forever grateful every single time that someone actually went through the process and managed to get a patch merged with or without my help. For more than five years already, I've done my best to salvage these contributions and ask for help but at the end of the day, most of the Ansible community projects are on GitHub and it has weighed down on me heavily to battle this inertia. Frankly, it has been exhausting and even depressing sometimes. I'm thankful for the OpenStack (and OpenDev) communities for hosting the project until now and hope to continue talking to you on freenode -- you can find me in #ara amongst many other channels. See you around ! [1]: https://github.com/ansible-community/ara/issues/205 [2]: https://dashboard.zuul.ansible.com/t/ansible/status David Moreau Simard dmsimard = [irc, github, twitter]
That move makes sense, it eases not only maintainer effort but also makes it easier for others to contribute. Congrats! -- /sorin On 25 Feb 2021 at 17:19:22, David Moreau Simard <dmsimard@redhat.com> wrote:
Hi openstack-discuss, long time no see o/
I've long dreaded doing this and sending this email out because I know how the community feels about proprietary platforms and I value the four opens that the OpenStack community has taught me so much about.
I've recently reached out and asked if people would be more likely to contribute to ara if pull requests were possible [1] and had a number of potential contributors interested.
Don't get me wrong: I still like OpenStack (have a cloud in my basement!) and personally prefer the Gerrit change workflow to the one on GitHub. However, I've come to the conclusion that my personal preferences should not be a barrier to contribution and so for the health and sustainability of the project I'll move the code review for ara to GitHub leveraging Ansible's Zuul deployment [2] for CI.
The truth is that ara never had many contributors and the few that were interested were often discouraged by the process involved in signing up and sending a change through Gerrit. It broke my heart to see a pull request being automatically closed with a template by an OpenStack bot. It broke my heart to have to tell people that they must jump through several hoops to send a patch. I was forever grateful every single time that someone actually went through the process and managed to get a patch merged with or without my help.
For more than five years already, I've done my best to salvage these contributions and ask for help but at the end of the day, most of the Ansible community projects are on GitHub and it has weighed down on me heavily to battle this inertia. Frankly, it has been exhausting and even depressing sometimes.
I'm thankful for the OpenStack (and OpenDev) communities for hosting the project until now and hope to continue talking to you on freenode -- you can find me in #ara amongst many other channels.
See you around !
[1]: https://github.com/ansible-community/ara/issues/205 [2]: https://dashboard.zuul.ansible.com/t/ansible/status
David Moreau Simard dmsimard = [irc, github, twitter]
:heart: I think there always comes a far amount of :this-is-my-view:, but as someone who is a bit outside the Gerrit Openstack ecosystem, I appreciate the simplicity of Github code reviews. There might be a scale of projects where the MR process on Github is too limited and integrations into external systems is harder. But for smaller projects that are mostly independent of bigger ones, it feels like a good compromise between flexibility and ease of use. I know that when I merged something for ARA, I ended up appreciating Gerrit but there is a definite learning curve that I don't feel was necessary to the process. On Thu, Feb 25, 2021 at 12:25 PM David Moreau Simard <dmsimard@redhat.com> wrote:
Hi openstack-discuss, long time no see o/
I've long dreaded doing this and sending this email out because I know how the community feels about proprietary platforms and I value the four opens that the OpenStack community has taught me so much about.
I've recently reached out and asked if people would be more likely to contribute to ara if pull requests were possible [1] and had a number of potential contributors interested.
Don't get me wrong: I still like OpenStack (have a cloud in my basement!) and personally prefer the Gerrit change workflow to the one on GitHub. However, I've come to the conclusion that my personal preferences should not be a barrier to contribution and so for the health and sustainability of the project I'll move the code review for ara to GitHub leveraging Ansible's Zuul deployment [2] for CI.
The truth is that ara never had many contributors and the few that were interested were often discouraged by the process involved in signing up and sending a change through Gerrit. It broke my heart to see a pull request being automatically closed with a template by an OpenStack bot. It broke my heart to have to tell people that they must jump through several hoops to send a patch. I was forever grateful every single time that someone actually went through the process and managed to get a patch merged with or without my help.
For more than five years already, I've done my best to salvage these contributions and ask for help but at the end of the day, most of the Ansible community projects are on GitHub and it has weighed down on me heavily to battle this inertia. Frankly, it has been exhausting and even depressing sometimes.
I'm thankful for the OpenStack (and OpenDev) communities for hosting the project until now and hope to continue talking to you on freenode -- you can find me in #ara amongst many other channels.
See you around !
[1]: https://github.com/ansible-community/ara/issues/205 [2]: https://dashboard.zuul.ansible.com/t/ansible/status
David Moreau Simard dmsimard = [irc, github, twitter]
Laurent Dumont wrote:
[...] I know that when I merged something for ARA, I ended up appreciating Gerrit but there is a definite learning curve that I don't feel was necessary to the process.
That's a great point. I personally think Gerrit is more efficient, but it's definitely different from the PR-based approach which the largest public code forges use (GitHub, Gitlab). Learning Gerrit is totally worth it if you intend to contribute regularly. It's harder to justify for a drive-by contribution, so you might miss those because the drive-by contributor sometimes just won't go through the hassle. So for a project like ARA which is mostly feature-complete, is not super busy and would at this point most likely attract drive-by contributions fixing corner case bugs and adding corner case use cases, I certainly understand your choice. -- Thierry
participants (4)
-
David Moreau Simard
-
Laurent Dumont
-
Sorin Sbarnea
-
Thierry Carrez