[neutron][all] Functional/tempest/rally jobs not running on changes
Hi, This might be affecting more than Neutron so I added the [all] tag, and is maybe being discussed in one of the #opendev channels and I missed it (?), but looking at a recent patch recheck shows a number of jobs not being run, for example [0] has just 11 jobs instead of 25 in the previous run. So for now I would not approve any changes since they could merge accidentally with broken code. I pinged gmann and he thought [1] might have caused this, and it just merged... so perhaps a quick revert is in order. -Brian [0] https://review.opendev.org/c/openstack/neutron/+/790060 [1] https://review.opendev.org/c/openstack/devstack/+/791541
---- On Fri, 04 Jun 2021 16:31:36 -0500 Brian Haley <haleyb.dev@gmail.com> wrote ----
Hi,
This might be affecting more than Neutron so I added the [all] tag, and is maybe being discussed in one of the #opendev channels and I missed it (?), but looking at a recent patch recheck shows a number of jobs not being run, for example [0] has just 11 jobs instead of 25 in the previous run.
So for now I would not approve any changes since they could merge accidentally with broken code.
I pinged gmann and he thought [1] might have caused this, and it just merged... so perhaps a quick revert is in order.
yeah, that is only patch in devstack side we merged.I have not clue why 791541 is causing the issue for check pipleline on master. gate pipeline is all fine and all the jobs are running there. Anyways I proposed the revert for now and meanwhile we can debug what went wrong with 'pragma'. - https://review.opendev.org/c/openstack/devstack/+/794822 -gmann
-Brian
[0] https://review.opendev.org/c/openstack/neutron/+/790060 [1] https://review.opendev.org/c/openstack/devstack/+/791541
On Fri, Jun 4, 2021, at 2:38 PM, Ghanshyam Mann wrote:
---- On Fri, 04 Jun 2021 16:31:36 -0500 Brian Haley <haleyb.dev@gmail.com> wrote ----
Hi,
This might be affecting more than Neutron so I added the [all] tag, and is maybe being discussed in one of the #opendev channels and I missed it (?), but looking at a recent patch recheck shows a number of jobs not being run, for example [0] has just 11 jobs instead of 25 in the previous run.
So for now I would not approve any changes since they could merge accidentally with broken code.
I pinged gmann and he thought [1] might have caused this, and it just merged... so perhaps a quick revert is in order.
yeah, that is only patch in devstack side we merged.I have not clue why 791541 is causing the issue for check pipleline on master. gate pipeline is all fine and all the jobs are running there. Anyways I proposed the revert for now and meanwhile we can debug what went wrong with 'pragma'.
Reading the docs [2] I think you need to include the current branch too. That pragma doesn't appear to be additive and instead defines the complete list. This means you not only need the feature/r1 branch but also master.
- https://review.opendev.org/c/openstack/devstack/+/794822
-gmann
-Brian
[0] https://review.opendev.org/c/openstack/neutron/+/790060 [1] https://review.opendev.org/c/openstack/devstack/+/791541
[2] https://zuul-ci.org/docs/zuul/reference/pragma_def.html#attr-pragma.implied-...
---- On Fri, 04 Jun 2021 16:38:35 -0500 Ghanshyam Mann <gmann@ghanshyammann.com> wrote ----
---- On Fri, 04 Jun 2021 16:31:36 -0500 Brian Haley <haleyb.dev@gmail.com> wrote ----
Hi,
This might be affecting more than Neutron so I added the [all] tag, and is maybe being discussed in one of the #opendev channels and I missed it (?), but looking at a recent patch recheck shows a number of jobs not being run, for example [0] has just 11 jobs instead of 25 in the previous run.
So for now I would not approve any changes since they could merge accidentally with broken code.
I pinged gmann and he thought [1] might have caused this, and it just merged... so perhaps a quick revert is in order.
yeah, that is only patch in devstack side we merged.I have not clue why 791541 is causing the issue for check pipleline on master. gate pipeline is all fine and all the jobs are running there. Anyways I proposed the revert for now and meanwhile we can debug what went wrong with 'pragma'.
This is merged now, please do recheck if any of your patch's check pipeline did not run the complete jobs. -gmann
-gmann
-Brian
[0] https://review.opendev.org/c/openstack/neutron/+/790060 [1] https://review.opendev.org/c/openstack/devstack/+/791541
Hi, There was a bunch of patches which tried to reduce the number of jobs executed for Neutron: https://review.opendev.org/q/topic:%22improve-neutron-ci%22+(status:open%20O...) worth checking it as perhaps some irrelevant file list needs to be updated. lajoskatona Ghanshyam Mann <gmann@ghanshyammann.com> ezt írta (időpont: 2021. jún. 6., V, 0:51):
---- On Fri, 04 Jun 2021 16:38:35 -0500 Ghanshyam Mann < gmann@ghanshyammann.com> wrote ----
---- On Fri, 04 Jun 2021 16:31:36 -0500 Brian Haley < haleyb.dev@gmail.com> wrote ----
Hi,
This might be affecting more than Neutron so I added the [all] tag, and is maybe being discussed in one of the #opendev channels and I missed it (?), but looking at a recent patch recheck shows a number of jobs not being run, for example [0] has just 11 jobs instead of 25 in the previous run.
So for now I would not approve any changes since they could merge accidentally with broken code.
I pinged gmann and he thought [1] might have caused this, and it just merged... so perhaps a quick revert is in order.
yeah, that is only patch in devstack side we merged.I have not clue why 791541 is causing the issue for check pipleline on master. gate pipeline is all fine and all the jobs are running there. Anyways I proposed the revert for now and meanwhile we can debug what went wrong with 'pragma'.
This is merged now, please do recheck if any of your patch's check pipeline did not run the complete jobs.
-gmann
-gmann
-Brian
[0] https://review.opendev.org/c/openstack/neutron/+/790060 [1] https://review.opendev.org/c/openstack/devstack/+/791541
participants (4)
-
Brian Haley
-
Clark Boylan
-
Ghanshyam Mann
-
Lajos Katona