[nova][placement] adding nova-core to placement-core in gerrit
Hi, Placement got back under nova governance but so far we haven't consolidated the core teams yet. Stephen pointed out to me that given the ongoing RBAC works it would be beneficial if more nova cores, with API and RBAC experience, could approve such patches. So I'm proposing to add nova-core group to the placement-core group in gerrit. This means Ghanshyam, John, Lee, and Melanie would get core rights in the placement related repositories. @placement-core, @nova-core members: Please let me know if you have any objection to such change until end of this week. cheers, gibi
Le mar. 26 janv. 2021 à 17:25, Balazs Gibizer <balazs.gibizer@est.tech> a écrit :
Hi,
Placement got back under nova governance but so far we haven't consolidated the core teams yet. Stephen pointed out to me that given the ongoing RBAC works it would be beneficial if more nova cores, with API and RBAC experience, could approve such patches. So I'm proposing to add nova-core group to the placement-core group in gerrit. This means Ghanshyam, John, Lee, and Melanie would get core rights in the placement related repositories.
@placement-core, @nova-core members: Please let me know if you have any objection to such change until end of this week.
No objection at all, let's be pragmatic. We originally asked who wanted to be placement-core but now, since the governance is the same, that's no longer an issue. -Sylvain
cheers, gibi
On Tue, 2021-01-26 at 17:34 +0100, Sylvain Bauza wrote:
Le mar. 26 janv. 2021 à 17:25, Balazs Gibizer <balazs.gibizer@est.tech> a écrit :
Hi,
Placement got back under nova governance but so far we haven't consolidated the core teams yet. Stephen pointed out to me that given the ongoing RBAC works it would be beneficial if more nova cores, with API and RBAC experience, could approve such patches. So I'm proposing to add nova-core group to the placement-core group in gerrit. This means Ghanshyam, John, Lee, and Melanie would get core rights in the placement related repositories.
@placement-core, @nova-core members: Please let me know if you have any objection to such change until end of this week.
No objection at all, let's be pragmatic. We originally asked who wanted to be placement-core but now, since the governance is the same, that's no longer an issue.
i think this is somewhat like the os-vif situation we added nova-core to os-vif and basically said, while we are granting you the right to appove an merge change in os-vif we are not requireing you to review them. if you feel comfortable in reviewing the code and feel you understand teh context then the nova cores were invited to use there new core right but if they did not have time, interest or knolage to do so then there was no pressure on them to use those new rights. so for placmnet i think common sense would imply the same approch. provided there is no object nova cores would be free to use there own judgement regarding reviewing and or approving changes based on there understanding of the code change but we are not nessisarly requireing the whole nova core team to activly review plamcent changes if its just not relevent to them.
-Sylvain
cheers, gibi
On Tue, 2021-01-26 at 17:34 +0100, Sylvain Bauza wrote:
Le mar. 26 janv. 2021 à 17:25, Balazs Gibizer <balazs.gibizer@est.tech> a écrit :
Hi,
Placement got back under nova governance but so far we haven't consolidated the core teams yet. Stephen pointed out to me that given the ongoing RBAC works it would be beneficial if more nova cores, with API and RBAC experience, could approve such patches. So I'm proposing to add nova-core group to the placement-core group in gerrit. This means Ghanshyam, John, Lee, and Melanie would get core rights in the placement related repositories.
@placement-core, @nova-core members: Please let me know if you have any objection to such change until end of this week.
No objection at all, let's be pragmatic. We originally asked who wanted to be placement-core but now, since the governance is the same, that's no longer an issue.
i think this is somewhat like the os-vif situation we added nova-core to os-vif and basically said, while we are granting you the right to appove an merge change in os-vif we are not requireing you to review them. if you feel comfortable in reviewing the code and feel you understand teh context then the nova cores were invited to use there new core right but if they did not have time, interest or knolage to do so then there was no pressure on them to use those new rights.
so for placmnet i think common sense would imply the same approch. provided there is no object nova cores would be free to use there own judgement regarding reviewing and or approving changes based on there understanding of the code change but we are not nessisarly requireing the whole nova core team to activly review plamcent changes if its just not relevent to them.
On Tue, 2021-01-26 at 16:50 +0000, Sean Mooney wrote: that was a +1 by the way
-Sylvain
cheers, gibi
On Tue, 2021-01-26 at 17:14 +0100, Balazs Gibizer wrote:
Hi,
Placement got back under nova governance but so far we haven't consolidated the core teams yet. Stephen pointed out to me that given the ongoing RBAC works it would be beneficial if more nova cores, with API and RBAC experience, could approve such patches. So I'm proposing to add nova-core group to the placement-core group in gerrit. This means Ghanshyam, John, Lee, and Melanie would get core rights in the placement related repositories.
@placement-core, @nova-core members: Please let me know if you have any objection to such change until end of this week.
I brought it up and obviously think it's a sensible idea, so it's an easy +1 from me. Stephen
cheers, gibi
Hi, I've now added nova-core to the placement-core group[1] [1] https://review.opendev.org/admin/groups/93c2b262ebfe0b3270c0b7ad60de887b02aa... On Wed, Jan 27, 2021 at 09:49, Stephen Finucane <stephenfin@redhat.com> wrote:
On Tue, 2021-01-26 at 17:14 +0100, Balazs Gibizer wrote:
Hi,
Placement got back under nova governance but so far we haven't consolidated the core teams yet. Stephen pointed out to me that given the ongoing RBAC works it would be beneficial if more nova cores, with API and RBAC experience, could approve such patches. So I'm proposing to add nova-core group to the placement-core group in gerrit. This means Ghanshyam, John, Lee, and Melanie would get core rights in the placement related repositories.
@placement-core, @nova-core members: Please let me know if you have any objection to such change until end of this week.
I brought it up and obviously think it's a sensible idea, so it's an easy +1 from me.
Stephen
cheers, gibi
On Tue, Feb 2, 2021 at 09:06, Balazs Gibizer <balazs.gibizer@est.tech> wrote:
Hi,
I've now added nova-core to the placement-core group[1]
It turned out that there is a separate placement-stable-maint group which does not have the nova-stable-maint included. Is there any objection to add nova-stable-maint to placement-stable-maint? Cheers, gibi
[1] https://review.opendev.org/admin/groups/93c2b262ebfe0b3270c0b7ad60de887b02aa...
On Wed, Jan 27, 2021 at 09:49, Stephen Finucane <stephenfin@redhat.com> wrote:
On Tue, 2021-01-26 at 17:14 +0100, Balazs Gibizer wrote:
Hi,
Placement got back under nova governance but so far we haven't consolidated the core teams yet. Stephen pointed out to me that given the ongoing RBAC works it would be beneficial if more nova cores, with API and RBAC experience, could approve such patches. So I'm proposing to add nova-core group to the placement-core group in gerrit. This means Ghanshyam, John, Lee, and Melanie would get core rights in the placement related repositories.
@placement-core, @nova-core members: Please let me know if you have any objection to such change until end of this week.
I brought it up and obviously think it's a sensible idea, so it's an easy +1 from me.
Stephen
cheers, gibi
On 03-02-21 10:43:12, Balazs Gibizer wrote:
On Tue, Feb 2, 2021 at 09:06, Balazs Gibizer <balazs.gibizer@est.tech> wrote:
Hi,
I've now added nova-core to the placement-core group[1]
It turned out that there is a separate placement-stable-maint group which does not have the nova-stable-maint included. Is there any objection to add nova-stable-maint to placement-stable-maint?
None from me as a member of nova-stable-maint. Thanks again for cleaning this up! -- Lee Yarwood A5D1 9385 88CB 7E5F BE64 6618 BCA6 6E33 F672 2D76
---- On Wed, 03 Feb 2021 05:01:42 -0600 Lee Yarwood <lyarwood@redhat.com> wrote ----
On 03-02-21 10:43:12, Balazs Gibizer wrote:
On Tue, Feb 2, 2021 at 09:06, Balazs Gibizer <balazs.gibizer@est.tech> wrote:
Hi,
I've now added nova-core to the placement-core group[1]
It turned out that there is a separate placement-stable-maint group which does not have the nova-stable-maint included. Is there any objection to add nova-stable-maint to placement-stable-maint?
+1, that makes sense. -gmann
None from me as a member of nova-stable-maint.
Thanks again for cleaning this up!
-- Lee Yarwood A5D1 9385 88CB 7E5F BE64 6618 BCA6 6E33 F672 2D76
On Wed, Feb 3, 2021 at 10:43, Balazs Gibizer <balazs.gibizer@est.tech> wrote:
On Tue, Feb 2, 2021 at 09:06, Balazs Gibizer <balazs.gibizer@est.tech> wrote:
Hi,
I've now added nova-core to the placement-core group[1]
It turned out that there is a separate placement-stable-maint group which does not have the nova-stable-maint included. Is there any objection to add nova-stable-maint to placement-stable-maint?
With Dan's help the nova-stable-maint is now part of placement-stable-maint. Cheers, gibi
Cheers, gibi
[1] https://review.opendev.org/admin/groups/93c2b262ebfe0b3270c0b7ad60de887b02aa...
On Wed, Jan 27, 2021 at 09:49, Stephen Finucane <stephenfin@redhat.com> wrote:
On Tue, 2021-01-26 at 17:14 +0100, Balazs Gibizer wrote:
Hi,
Placement got back under nova governance but so far we haven't consolidated the core teams yet. Stephen pointed out to me that given the ongoing RBAC works it would be beneficial if more nova cores, with API and RBAC experience, could approve such patches. So I'm proposing to add nova-core group to the placement-core group in gerrit. This means Ghanshyam, John, Lee, and Melanie would get core rights in the placement related repositories.
@placement-core, @nova-core members: Please let me know if you have any objection to such change until end of this week.
I brought it up and obviously think it's a sensible idea, so it's an easy +1 from me.
Stephen
cheers, gibi
participants (6)
-
Balazs Gibizer
-
Ghanshyam Mann
-
Lee Yarwood
-
Sean Mooney
-
Stephen Finucane
-
Sylvain Bauza