[oslo][tooz][requirements] Tooz etcd3 tests blocked on grpcio>=1.16.0
The tooz gate is currently blocked on https://bugs.launchpad.net/python-tooz/+bug/1808046 which seems to have been introduced with grpcio 1.16.0. I need to raise that issue with the grpc folks, but in the meantime should we block the problematic versions? grpcio isn't currently in g-r and I can't remember what our policy on transitive dependencies is, so I thought I'd solicit opinions. Thanks. -Ben
On 18-12-11 17:03:12, Ben Nemec wrote:
The tooz gate is currently blocked on https://bugs.launchpad.net/python-tooz/+bug/1808046 which seems to have been introduced with grpcio 1.16.0. I need to raise that issue with the grpc folks, but in the meantime should we block the problematic versions? grpcio isn't currently in g-r and I can't remember what our policy on transitive dependencies is, so I thought I'd solicit opinions.
I'm not aware of any policy on how we block dependencies like this. At the moment I'd suggest opening a bug with us so we don't forget and add it to global-requirements (preferably with a comment). Answering all the questions as normal. https://storyboard.openstack.org/#!/project/openstack/requirements -- Matthew Thode (prometheanfire)
On 18-12-11 17:03:12, Ben Nemec wrote:
The tooz gate is currently blocked on https://bugs.launchpad.net/python-tooz/+bug/1808046 which seems to have been introduced with grpcio 1.16.0. I need to raise that issue with the grpc folks, but in the meantime should we block the problematic versions? grpcio isn't currently in g-r and I can't remember what our policy on transitive dependencies is, so I thought I'd solicit opinions.
Thanks.
I'm not aware of any policy on how we block dependencies like this. At the moment I'd suggest opening a bug with us so we don't forget and add it to global-requirements (preferably with a comment). Answering all the questions as normal. https://storyboard.openstack.org/#!/project/openstack/requirements -- Matthew Thode (prometheanfire)
On Tue, Dec 11, 2018 at 05:03:12PM -0600, Ben Nemec wrote:
The tooz gate is currently blocked on https://bugs.launchpad.net/python-tooz/+bug/1808046 which seems to have been introduced with grpcio 1.16.0. I need to raise that issue with the grpc folks, but in the meantime should we block the problematic versions? grpcio isn't currently in g-r and I can't remember what our policy on transitive dependencies is, so I thought I'd solicit opinions.
Yup just add it in this section: http://git.openstack.org/cgit/openstack/requirements/tree/global-requirement... Bonus points if you have a second patch that removes daiquiri from that section as we're clearly not blocking version any more. Yours Tony.
On Tue, Dec 11, 2018, at 6:35 PM, Tony Breeds wrote:
On Tue, Dec 11, 2018 at 05:03:12PM -0600, Ben Nemec wrote:
The tooz gate is currently blocked on https://bugs.launchpad.net/python-tooz/+bug/1808046 which seems to have been introduced with grpcio 1.16.0. I need to raise that issue with the grpc folks, but in the meantime should we block the problematic versions? grpcio isn't currently in g-r and I can't remember what our policy on transitive dependencies is, so I thought I'd solicit opinions.
Yup just add it in this section: http://git.openstack.org/cgit/openstack/requirements/tree/global-requirement...
Do we need to have the constraints generation tooling install tooz[etcd3] so that the transitive dep for grpcio is installed too? Or will that get pulled in because it is in global-requirements? Enough has changed in how this all works I'm not totally sure what is necessary anymore but tooz lists etcd3 as an extra requires so you have to ask for it to get those deps. Clark
On Tue, Dec 11, 2018 at 06:37:45PM -0800, Clark Boylan wrote:
Do we need to have the constraints generation tooling install tooz[etcd3] so that the transitive dep for grpcio is installed too?
We do not.
Or will that get pulled in because it is in global-requirements?
Yes that one :D Yours Tony.
On 18-12-11 18:37:45, Clark Boylan wrote:
On Tue, Dec 11, 2018, at 6:35 PM, Tony Breeds wrote:
On Tue, Dec 11, 2018 at 05:03:12PM -0600, Ben Nemec wrote:
The tooz gate is currently blocked on https://bugs.launchpad.net/python-tooz/+bug/1808046 which seems to have been introduced with grpcio 1.16.0. I need to raise that issue with the grpc folks, but in the meantime should we block the problematic versions? grpcio isn't currently in g-r and I can't remember what our policy on transitive dependencies is, so I thought I'd solicit opinions.
Yup just add it in this section: http://git.openstack.org/cgit/openstack/requirements/tree/global-requirement...
Do we need to have the constraints generation tooling install tooz[etcd3] so that the transitive dep for grpcio is installed too? Or will that get pulled in because it is in global-requirements?
Enough has changed in how this all works I'm not totally sure what is necessary anymore but tooz lists etcd3 as an extra requires so you have to ask for it to get those deps.
ya, it should be in global-requirements if it's an extra dep, the reason why gating didn't catch it is because it's not checking. see http://logs.openstack.org/47/624247/3/check/requirements-check/f8b35d2/job-o... for example. going to see if I can add that... -- Matthew Thode
On 18-12-11 20:54:03, Matthew Thode wrote:
On 18-12-11 18:37:45, Clark Boylan wrote:
On Tue, Dec 11, 2018, at 6:35 PM, Tony Breeds wrote:
On Tue, Dec 11, 2018 at 05:03:12PM -0600, Ben Nemec wrote:
The tooz gate is currently blocked on https://bugs.launchpad.net/python-tooz/+bug/1808046 which seems to have been introduced with grpcio 1.16.0. I need to raise that issue with the grpc folks, but in the meantime should we block the problematic versions? grpcio isn't currently in g-r and I can't remember what our policy on transitive dependencies is, so I thought I'd solicit opinions.
Yup just add it in this section: http://git.openstack.org/cgit/openstack/requirements/tree/global-requirement...
Do we need to have the constraints generation tooling install tooz[etcd3] so that the transitive dep for grpcio is installed too? Or will that get pulled in because it is in global-requirements?
Enough has changed in how this all works I'm not totally sure what is necessary anymore but tooz lists etcd3 as an extra requires so you have to ask for it to get those deps.
ya, it should be in global-requirements if it's an extra dep, the reason why gating didn't catch it is because it's not checking.
see http://logs.openstack.org/47/624247/3/check/requirements-check/f8b35d2/job-o... for example.
going to see if I can add that...
Ignore this, I thought we were talking about grpcio being in listed as a direct (optional) dependency. Time to go to sleep. -- Matthew Thode
On 12/11/18 8:35 PM, Tony Breeds wrote:
On Tue, Dec 11, 2018 at 05:03:12PM -0600, Ben Nemec wrote:
The tooz gate is currently blocked on https://bugs.launchpad.net/python-tooz/+bug/1808046 which seems to have been introduced with grpcio 1.16.0. I need to raise that issue with the grpc folks, but in the meantime should we block the problematic versions? grpcio isn't currently in g-r and I can't remember what our policy on transitive dependencies is, so I thought I'd solicit opinions.
Yup just add it in this section: http://git.openstack.org/cgit/openstack/requirements/tree/global-requirement...
Done: https://review.openstack.org/624759
Bonus points if you have a second patch that removes daiquiri from that section as we're clearly not blocking version any more.
And done: https://review.openstack.org/624760
Yours Tony.
participants (5)
-
Ben Nemec
-
Clark Boylan
-
Matthew Thode
-
Matthew Thode
-
Tony Breeds