Are most grenade plugin projects doing upgrades wrong?
While fixing how the watcher grenade plugin is cloning the watcher repo for the base (old) side [1] to hard-code from stable/rocky to stable/stien, I noticed that several other projects with grenade plugins aren't actually setting a stable branch when cloning the plugin for the old side [2]. So I tried removing the stable/stein branch from the base plugin clone in watcher [3] and grenade cloned from master for the base (old) side [4]. Taking designate as an example, I see the same thing happening for it's grenade run [5].
Is there something I'm missing here or are most of the openstack projects running grenade via plugin actually just upgrading from master to master rather than n-1 to master?
[1] https://review.opendev.org/#/c/664610/1/devstack/upgrade/settings [2] http://codesearch.openstack.org/?q=base%20enable_plugin&i=nope&files... [3] https://review.opendev.org/#/c/664610/2/devstack/upgrade/settings [4] http://logs.openstack.org/10/664610/2/check/watcher-grenade/ad2e068/logs/gre... [5] http://logs.openstack.org/47/662647/6/check/designate-grenade-pdns4/0b8968f/...
Actually, if you check [4] and [5], they seemingly check out master, but just below the linked line like 20 lines, there's a 'git show --oneline' and 'head -1' which shows that the branch is clearly stable/stein. So it seems there's no need for explicit branch settings in [1]... but I haven't found the code lines which cause this behavior, yet...
BR,
Előd
On 2019. 06. 13. 15:45, Matt Riedemann wrote:
While fixing how the watcher grenade plugin is cloning the watcher repo for the base (old) side [1] to hard-code from stable/rocky to stable/stien, I noticed that several other projects with grenade plugins aren't actually setting a stable branch when cloning the plugin for the old side [2]. So I tried removing the stable/stein branch from the base plugin clone in watcher [3] and grenade cloned from master for the base (old) side [4]. Taking designate as an example, I see the same thing happening for it's grenade run [5].
Is there something I'm missing here or are most of the openstack projects running grenade via plugin actually just upgrading from master to master rather than n-1 to master?
[1] https://review.opendev.org/#/c/664610/1/devstack/upgrade/settings [2] http://codesearch.openstack.org/?q=base%20enable_plugin&i=nope&files... [3] https://review.opendev.org/#/c/664610/2/devstack/upgrade/settings [4] http://logs.openstack.org/10/664610/2/check/watcher-grenade/ad2e068/logs/gre... [5] http://logs.openstack.org/47/662647/6/check/designate-grenade-pdns4/0b8968f/... --
Thanks,
Matt
---- On Fri, 14 Jun 2019 01:13:33 +0900 Elõd Illés elod.illes@ericsson.com wrote ----
Actually, if you check [4] and [5], they seemingly check out master, but just below the linked line like 20 lines, there's a 'git show --oneline' and 'head -1' which shows that the branch is clearly stable/stein. So it seems there's no need for explicit branch settings in [1]... but I haven't found the code lines which cause this behavior, yet...
yeah, it seems it did checkout stein version. But from log it is not clear where exactly /opt.stack/old/watcher dir is being cloned from stein? this is the first clone I am seeing in log[6].
I checked for designate grenade job on stein and rocky branch and they also seem to clone the correct base designate [7].
Are we missing the log somewhere where the correct base is cloned?
[6] http://logs.openstack.org/10/664610/2/check/watcher-grenade/ad2e068/logs/old... [7] stein- http://logs.openstack.org/71/660171/1/check/designate-grenade-pdns4/a460998/... rocky- http://logs.openstack.org/60/662760/1/check/designate-grenade-pdns4/940dc47/...
-gmann
BR,
Előd
On 2019. 06. 13. 15:45, Matt Riedemann wrote:
While fixing how the watcher grenade plugin is cloning the watcher repo for the base (old) side [1] to hard-code from stable/rocky to stable/stien, I noticed that several other projects with grenade plugins aren't actually setting a stable branch when cloning the plugin for the old side [2]. So I tried removing the stable/stein branch from the base plugin clone in watcher [3] and grenade cloned from master for the base (old) side [4]. Taking designate as an example, I see the same thing happening for it's grenade run [5].
Is there something I'm missing here or are most of the openstack projects running grenade via plugin actually just upgrading from master to master rather than n-1 to master?
[1] https://review.opendev.org/#/c/664610/1/devstack/upgrade/settings [2] http://codesearch.openstack.org/?q=base%20enable_plugin&i=nope&files... [3] https://review.opendev.org/#/c/664610/2/devstack/upgrade/settings [4] http://logs.openstack.org/10/664610/2/check/watcher-grenade/ad2e068/logs/gre... [5] http://logs.openstack.org/47/662647/6/check/designate-grenade-pdns4/0b8968f/... --
Thanks,
Matt
participants (3)
-
Elõd Illés
-
Ghanshyam Mann
-
Matt Riedemann