Hi team, One of the thing that has been brought up in the last meeting is what is the process of merging a patch. So, let's try this first: - For small patches (e.g., change strings, fix typos, update docs): any core can approve for merging. - For a patch that implements a new feature, removes a feature, patch that has huge changes (in the number of changed files and loc, etc.) or any patch that is in doubt: we need at least 2 cores to give a +2 and then the PTL will merge it. Of course, we can change the procedure when we see issues. For now, this should be a guideline for the team. Please feel free to comment. Yours, -- *Trinh Nguyen* *www.edlab.xyz <https://www.edlab.xyz>*
Hi, As usual, There are have +2s, then the next core can +2/A, why we need PTL final +A? Thanks, Rong Zhu Trinh Nguyen <dangtrinhnt@gmail.com>于2019年4月11日 周四15:39写道：
Hi team,
One of the thing that has been brought up in the last meeting is what is the process of merging a patch. So, let's try this first:
- For small patches (e.g., change strings, fix typos, update docs): any core can approve for merging. - For a patch that implements a new feature, removes a feature, patch that has huge changes (in the number of changed files and loc, etc.) or any patch that is in doubt: we need at least 2 cores to give a +2 and then the PTL will merge it.
Of course, we can change the procedure when we see issues. For now, this should be a guideline for the team.
Please feel free to comment.
Yours,
-- *Trinh Nguyen* *www.edlab.xyz <https://www.edlab.xyz>*
-- Thanks, Rong Zhu
Ok, that makes sense to me. On Thu, Apr 11, 2019 at 4:50 PM Rong Zhu <aaronzhu1121@gmail.com> wrote:
Hi,
As usual, There are have +2s, then the next core can +2/A, why we need PTL final +A?
Thanks, Rong Zhu
Trinh Nguyen <dangtrinhnt@gmail.com>于2019年4月11日 周四15:39写道：
Hi team,
One of the thing that has been brought up in the last meeting is what is the process of merging a patch. So, let's try this first:
- For small patches (e.g., change strings, fix typos, update docs): any core can approve for merging. - For a patch that implements a new feature, removes a feature, patch that has huge changes (in the number of changed files and loc, etc.) or any patch that is in doubt: we need at least 2 cores to give a +2 and then the PTL will merge it.
Of course, we can change the procedure when we see issues. For now, this should be a guideline for the team.
Please feel free to comment.
Yours,
-- *Trinh Nguyen* *www.edlab.xyz <https://www.edlab.xyz>*
-- Thanks, Rong Zhu
-- *Trinh Nguyen* *www.edlab.xyz <https://www.edlab.xyz>*
I meant I totally agree with what you're saying. If a core has already put a +2 on a patch, the next core can approve. On Thu, Apr 11, 2019 at 4:51 PM Trinh Nguyen <dangtrinhnt@gmail.com> wrote:
Ok, that makes sense to me.
On Thu, Apr 11, 2019 at 4:50 PM Rong Zhu <aaronzhu1121@gmail.com> wrote:
Hi,
As usual, There are have +2s, then the next core can +2/A, why we need PTL final +A?
Thanks, Rong Zhu
Trinh Nguyen <dangtrinhnt@gmail.com>于2019年4月11日 周四15:39写道：
Hi team,
One of the thing that has been brought up in the last meeting is what is the process of merging a patch. So, let's try this first:
- For small patches (e.g., change strings, fix typos, update docs): any core can approve for merging. - For a patch that implements a new feature, removes a feature, patch that has huge changes (in the number of changed files and loc, etc.) or any patch that is in doubt: we need at least 2 cores to give a +2 and then the PTL will merge it.
Of course, we can change the procedure when we see issues. For now, this should be a guideline for the team.
Please feel free to comment.
Yours,
-- *Trinh Nguyen* *www.edlab.xyz <https://www.edlab.xyz>*
-- Thanks, Rong Zhu
-- *Trinh Nguyen* *www.edlab.xyz <https://www.edlab.xyz>*
-- *Trinh Nguyen* *www.edlab.xyz <https://www.edlab.xyz>*
participants (2)
-
Rong Zhu
-
Trinh Nguyen