[neutron][drivers][ironic] FFE request - Use openstacksdk for ironic notifiers
Hello fellow openstackers,
I'd like to open an FFE request to convert the ironic events notifier from the current ironicclient to openstacksdk with the change https://review.opendev.org/682040 This requires also a bump of the versions of mock and openstacksdk in lower-constraints, included in the CR. The change has been tested in a devstack environment and passes the zuul checks.
Thank you!
Riccardo Pittau rpittau||elfosardo
I'd like to open an FFE request to convert the ironic events notifier from the current ironicclient to openstacksdk with the change https://review.opendev.org/682040
This is kind of none of my business, but since the existing ironic stuff was only introduced in Train [1], IMO it is important to allow this FFE so neutron doesn't have to go through the pain of supporting and deprecating the conf options (e.g. `ironic_url`) and code paths through python-ironicclient.
efried
Hi,
Personally I think we can go with this is You will implement it now. As per discussion on IRC, Ironic code which will use those notifications isn't really ready yet, and will not be for Train. So even if something would possible go wrong (but won't for sure ;)) we shouldn't break Ironic.
On Wed, Sep 18, 2019 at 11:04:54AM -0500, Eric Fried wrote:
I'd like to open an FFE request to convert the ironic events notifier from the current ironicclient to openstacksdk with the change https://review.opendev.org/682040
This is kind of none of my business, but since the existing ironic stuff was only introduced in Train [1], IMO it is important to allow this FFE so neutron doesn't have to go through the pain of supporting and deprecating the conf options (e.g. `ironic_url`) and code paths through python-ironicclient.
Thx. I agree. That's another good point to accept this FFE.
efried
Hi,
This FFE is approved
Thanks
On Wed, Sep 18, 2019 at 2:45 PM Slawek Kaplonski skaplons@redhat.com wrote:
Hi,
Personally I think we can go with this is You will implement it now. As per discussion on IRC, Ironic code which will use those notifications isn't really ready yet, and will not be for Train. So even if something would possible go wrong (but won't for sure ;)) we shouldn't break Ironic.
On Wed, Sep 18, 2019 at 11:04:54AM -0500, Eric Fried wrote:
I'd like to open an FFE request to convert the ironic events notifier from the current ironicclient to openstacksdk with the change https://review.opendev.org/682040
This is kind of none of my business, but since the existing ironic stuff was only introduced in Train [1], IMO it is important to allow this FFE so neutron doesn't have to go through the pain of supporting and deprecating the conf options (e.g. `ironic_url`) and code paths through python-ironicclient.
Thx. I agree. That's another good point to accept this FFE.
efried
-- Slawek Kaplonski Senior software engineer Red Hat
The patch has merged Thanks all!
On Wed, 18 Sep 2019 at 23:35, Miguel Lavalle miguel@mlavalle.com wrote:
Hi,
This FFE is approved
Thanks
On Wed, Sep 18, 2019 at 2:45 PM Slawek Kaplonski skaplons@redhat.com wrote:
Hi,
Personally I think we can go with this is You will implement it now. As per discussion on IRC, Ironic code which will use those notifications isn't really ready yet, and will not be for Train. So even if something would possible go wrong (but won't for sure ;)) we shouldn't break Ironic.
On Wed, Sep 18, 2019 at 11:04:54AM -0500, Eric Fried wrote:
I'd like to open an FFE request to convert the ironic events notifier from the current ironicclient to openstacksdk with the change https://review.opendev.org/682040
This is kind of none of my business, but since the existing ironic stuff was only introduced in Train [1], IMO it is important to allow this FFE so neutron doesn't have to go through the pain of supporting and deprecating the conf options (e.g. `ironic_url`) and code paths through python-ironicclient.
Thx. I agree. That's another good point to accept this FFE.
efried
-- Slawek Kaplonski Senior software engineer Red Hat
Hi,
Thx Riccardo for working on this :)
On Mon, Sep 23, 2019 at 10:32:15AM +0200, Riccardo Pittau wrote:
The patch has merged Thanks all!
On Wed, 18 Sep 2019 at 23:35, Miguel Lavalle miguel@mlavalle.com wrote:
Hi,
This FFE is approved
Thanks
On Wed, Sep 18, 2019 at 2:45 PM Slawek Kaplonski skaplons@redhat.com wrote:
Hi,
Personally I think we can go with this is You will implement it now. As per discussion on IRC, Ironic code which will use those notifications isn't really ready yet, and will not be for Train. So even if something would possible go wrong (but won't for sure ;)) we shouldn't break Ironic.
On Wed, Sep 18, 2019 at 11:04:54AM -0500, Eric Fried wrote:
I'd like to open an FFE request to convert the ironic events notifier from the current ironicclient to openstacksdk with the change https://review.opendev.org/682040
This is kind of none of my business, but since the existing ironic stuff was only introduced in Train [1], IMO it is important to allow this FFE so neutron doesn't have to go through the pain of supporting and deprecating the conf options (e.g. `ironic_url`) and code paths through python-ironicclient.
Thx. I agree. That's another good point to accept this FFE.
efried
-- Slawek Kaplonski Senior software engineer Red Hat
participants (4)
-
Eric Fried
-
Miguel Lavalle
-
Riccardo Pittau
-
Slawek Kaplonski