[nova] Running multinode resize tests in the gate
Yo Novans, In trying to understand why my partial fix to bug 1813789 [1] - specifically the part where reverting a resize fails because we get the network-vif-plugged event from Neutron before we start listening for it - I noticed that we don't test multinode resize (and revert) in the gate. As far as I can tell, the only place where the revert tests are run are in tempest-full-py3, and that's on an allinone single node. In order to test a theory of mine about revert resize on the same node vs source to dest and back again, I do have a DNM patch up [2] to run the resize tests in the nova-live-migration job - I think that's the only multinode tempest job we have, right? I think that job also runs evacuation tests [3], correct? So, should we just rename it nova-multinode and add resize to the list of tests it runs? [1] https://bugs.launchpad.net/nova/+bug/1813789 [2] https://review.openstack.org/#/c/653498/ [3] https://github.com/openstack/nova/blob/54d8b40471e6f7b36dbe45966c1c605f94d49...
On 4/18/2019 1:04 PM, Artom Lifshitz wrote:
Yo Novans,
In trying to understand why my partial fix to bug 1813789 [1] - specifically the part where reverting a resize fails because we get the network-vif-plugged event from Neutron before we start listening for it - I noticed that we don't test multinode resize (and revert) in the gate. As far as I can tell, the only place where the revert tests are run are in tempest-full-py3, and that's on an allinone single node.
In order to test a theory of mine about revert resize on the same node vs source to dest and back again, I do have a DNM patch up [2] to run the resize tests in the nova-live-migration job - I think that's the only multinode tempest job we have, right? I think that job also runs evacuation tests [3], correct? So, should we just rename it nova-multinode and add resize to the list of tests it runs?
[1]https://bugs.launchpad.net/nova/+bug/1813789 [2]https://review.openstack.org/#/c/653498/ [3]https://github.com/openstack/nova/blob/54d8b40471e6f7b36dbe45966c1c605f94d49...
We used to run tempest-multinode-full until recently [1]. That's probably what you're looking for, but I don't really want to add that job back for the reasons mentioned in the commit message and associated mailing list thread. We could make nova-next multinode but then we start having overlap with nova-live-migration (minus the evacuate testing) and tempest-slow. The tempest-slow job is also multinode but apparently there aren't any resize tests marked slow so those don't get run in that job. So...enabling resize tests in nova-live-migration is probably the best option at this point, and yeah likely means renaming it as well (since it's already confusingly named nova-live-migration but also runs evacuate tests too via a post-test hook). The only thing I worry about with that one is needing to keep a regex of tempest tests we run, but technically we're already doing that for the live migration tests [2]. Maybe it's time to bite the bullet and use a real rc file like we have for some other jobs, e.g. [3]. [1] https://github.com/openstack/nova/commit/95e782dfd86caa4201d28ee86ba2bb475e0... [2] https://github.com/openstack/nova/blob/95e782dfd86caa4201d28ee86ba2bb475e0a4... [3] https://github.com/openstack/nova/blob/95e782dfd86caa4201d28ee86ba2bb475e0a4... -- Thanks, Matt
in h On Fri, Apr 19, 2019 at 4:42 PM Matt Riedemann <mriedemos@gmail.com> wrote:
So...enabling resize tests in nova-live-migration is probably the best option at this point, and yeah likely means renaming it as well (since it's already confusingly named nova-live-migration but also runs evacuate tests too via a post-test hook). The only thing I worry about with that one is needing to keep a regex of tempest tests we run, but technically we're already doing that for the live migration tests [2].
Maybe it's time to bite the bullet and use a real rc file like we have for some other jobs, e.g. [3].
I don't think that's going to be possible, given that we do things like change Tempest settings [4] and start Glance [5], and then the evacuate tests force down a compute [6]. But maybe the resize tests can at least use a real rc file. I'll re-work the patch [7] and un-DNM it. [4] https://github.com/openstack/nova/blob/95e782dfd86caa4201d28ee86ba2bb475e0a4... [5] https://github.com/openstack/nova/blob/95e782dfd86caa4201d28ee86ba2bb475e0a4... [6] https://github.com/openstack/nova/blob/95e782dfd86caa4201d28ee86ba2bb475e0a4... [7] https://review.openstack.org/#/c/653498/
[1] https://github.com/openstack/nova/commit/95e782dfd86caa4201d28ee86ba2bb475e0... [2] https://github.com/openstack/nova/blob/95e782dfd86caa4201d28ee86ba2bb475e0a4... [3] https://github.com/openstack/nova/blob/95e782dfd86caa4201d28ee86ba2bb475e0a4...
--
Thanks,
Matt
participants (2)
-
Artom Lifshitz
-
Matt Riedemann