[horizon] [infra] horizon stable gate failure: yarn is required?
Hi, nodejs4 jobs in stein and older stable branches in horizon are now failing [1]. The symptom is that "yarn --version" fails during ensure-yarn [2]. It looks like that yarn now requires nodejs 10 or later and does not support nodejs4. The failure happens in the jobs on ubuntu-xenial nodes. When I try nodejs10 in stable/stein, the nodejs4 jobs (lint/run) succeeded [3]. My question is whether we need to install yarn in the pre-run? horizon does not require yarn. All nodejs jobs inherit nodejs-npm job defined in zuul/zuul-jobs and the pre-run playbook [4] installs yarn. I am not sure when we started to require yarn and who requires yarn. Generally speaking, I don't think it is a good idea to switch the nodejs version in these older stable branches. horizon and horizon plugins use nodejs only for testing, so if switching to nodejs10 would solve the failure completely, it might be an option too though. Thought? -amotoki [1] https://review.opendev.org/#/q/topic:health-check+status:open+project:openst... [2] https://zuul.opendev.org/t/openstack/build/72317c21cf7b4a1a885b9a26c5ae4c2d/... [3] https://review.opendev.org/#/c/726702/ [4] https://opendev.org/zuul/zuul-jobs/src/branch/master/playbooks/javascript/pr...
Hi Akihiro, from my PoV yarn should be installed by projects that require it, especially since it's not baked into the instance image but tried to be installed each time (and hence causes these late failures). Since the jobs are now broken anyway, I think removing yarn from pre play is the right move. Obviously, ensure-yarn has to be fixed to be useful for those parties who require yarn and older nodejs. And "those parties" in case of OpenStack seem to be only RefStack, which means there is only one project to adapt then. -yoctozepto On 2020-05-11 06:21, Akihiro Motoki wrote:
Hi,
nodejs4 jobs in stein and older stable branches in horizon are now failing [1]. The symptom is that "yarn --version" fails during ensure-yarn [2].
It looks like that yarn now requires nodejs 10 or later and does not support nodejs4. The failure happens in the jobs on ubuntu-xenial nodes. When I try nodejs10 in stable/stein, the nodejs4 jobs (lint/run) succeeded [3].
My question is whether we need to install yarn in the pre-run? horizon does not require yarn. All nodejs jobs inherit nodejs-npm job defined in zuul/zuul-jobs and the pre-run playbook [4] installs yarn. I am not sure when we started to require yarn and who requires yarn.
Generally speaking, I don't think it is a good idea to switch the nodejs version in these older stable branches. horizon and horizon plugins use nodejs only for testing, so if switching to nodejs10 would solve the failure completely, it might be an option too though.
Thought?
-amotoki
[1] https://review.opendev.org/#/q/topic:health-check+status:open+project:openst... [2] https://zuul.opendev.org/t/openstack/build/72317c21cf7b4a1a885b9a26c5ae4c2d/... [3] https://review.opendev.org/#/c/726702/ [4] https://opendev.org/zuul/zuul-jobs/src/branch/master/playbooks/javascript/pr...
On May 11, 2020, at 2:42 AM, Radosław Piliszek <radoslaw.piliszek@gmail.com> wrote:
Hi Akihiro,
from my PoV yarn should be installed by projects that require it, especially since it's not baked into the instance image but tried to be installed each time (and hence causes these late failures).
Since the jobs are now broken anyway, I think removing yarn from pre play is the right move. Obviously, ensure-yarn has to be fixed to be useful for those parties who require yarn and older nodejs. And "those parties" in case of OpenStack seem to be only RefStack, which means there is only one project to adapt then.
What good timing - I was actually working on updated javascript jobs over the weekend: https://review.opendev.org/726547 I think we can update that to also only install yarn when it’s going to use yarn, I’ll make an update - and then I think if we update horizon to the new jobs this should be no problem.
-yoctozepto
On 2020-05-11 06:21, Akihiro Motoki wrote:
Hi, nodejs4 jobs in stein and older stable branches in horizon are now failing [1]. The symptom is that "yarn --version" fails during ensure-yarn [2]. It looks like that yarn now requires nodejs 10 or later and does not support nodejs4. The failure happens in the jobs on ubuntu-xenial nodes. When I try nodejs10 in stable/stein, the nodejs4 jobs (lint/run) succeeded [3]. My question is whether we need to install yarn in the pre-run? horizon does not require yarn. All nodejs jobs inherit nodejs-npm job defined in zuul/zuul-jobs and the pre-run playbook [4] installs yarn. I am not sure when we started to require yarn and who requires yarn. Generally speaking, I don't think it is a good idea to switch the nodejs version in these older stable branches. horizon and horizon plugins use nodejs only for testing, so if switching to nodejs10 would solve the failure completely, it might be an option too though. Thought? -amotoki [1] https://review.opendev.org/#/q/topic:health-check+status:open+project:openst... [2] https://zuul.opendev.org/t/openstack/build/72317c21cf7b4a1a885b9a26c5ae4c2d/... [3] https://review.opendev.org/#/c/726702/ [4] https://opendev.org/zuul/zuul-jobs/src/branch/master/playbooks/javascript/pr...
On May 11, 2020, at 10:54 AM, Monty Taylor <mordred@inaugust.com> wrote:
On May 11, 2020, at 2:42 AM, Radosław Piliszek <radoslaw.piliszek@gmail.com> wrote:
Hi Akihiro,
from my PoV yarn should be installed by projects that require it, especially since it's not baked into the instance image but tried to be installed each time (and hence causes these late failures).
Since the jobs are now broken anyway, I think removing yarn from pre play is the right move. Obviously, ensure-yarn has to be fixed to be useful for those parties who require yarn and older nodejs. And "those parties" in case of OpenStack seem to be only RefStack, which means there is only one project to adapt then.
What good timing - I was actually working on updated javascript jobs over the weekend:
https://review.opendev.org/726547
I think we can update that to also only install yarn when it’s going to use yarn, I’ll make an update - and then I think if we update horizon to the new jobs this should be no problem.
Updated - maybe a patch to horizon on the v4 stable branches with a depends-on that patch updating to the new jobs would validate that the new jobs fix the issue?
-yoctozepto
On 2020-05-11 06:21, Akihiro Motoki wrote:
Hi, nodejs4 jobs in stein and older stable branches in horizon are now failing [1]. The symptom is that "yarn --version" fails during ensure-yarn [2]. It looks like that yarn now requires nodejs 10 or later and does not support nodejs4. The failure happens in the jobs on ubuntu-xenial nodes. When I try nodejs10 in stable/stein, the nodejs4 jobs (lint/run) succeeded [3]. My question is whether we need to install yarn in the pre-run? horizon does not require yarn. All nodejs jobs inherit nodejs-npm job defined in zuul/zuul-jobs and the pre-run playbook [4] installs yarn. I am not sure when we started to require yarn and who requires yarn. Generally speaking, I don't think it is a good idea to switch the nodejs version in these older stable branches. horizon and horizon plugins use nodejs only for testing, so if switching to nodejs10 would solve the failure completely, it might be an option too though. Thought? -amotoki [1] https://review.opendev.org/#/q/topic:health-check+status:open+project:openst... [2] https://zuul.opendev.org/t/openstack/build/72317c21cf7b4a1a885b9a26c5ae4c2d/... [3] https://review.opendev.org/#/c/726702/ [4] https://opendev.org/zuul/zuul-jobs/src/branch/master/playbooks/javascript/pr...
On 11/05/2020 18.19, Monty Taylor wrote:
On May 11, 2020, at 10:54 AM, Monty Taylor <mordred@inaugust.com> wrote:
On May 11, 2020, at 2:42 AM, Radosław Piliszek <radoslaw.piliszek@gmail.com> wrote:
Hi Akihiro,
from my PoV yarn should be installed by projects that require it, especially since it's not baked into the instance image but tried to be installed each time (and hence causes these late failures).
Since the jobs are now broken anyway, I think removing yarn from pre play is the right move. Obviously, ensure-yarn has to be fixed to be useful for those parties who require yarn and older nodejs. And "those parties" in case of OpenStack seem to be only RefStack, which means there is only one project to adapt then.
What good timing - I was actually working on updated javascript jobs over the weekend:
https://review.opendev.org/726547
I think we can update that to also only install yarn when it’s going to use yarn, I’ll make an update - and then I think if we update horizon to the new jobs this should be no problem.
Updated - maybe a patch to horizon on the v4 stable branches with a depends-on that patch updating to the new jobs would validate that the new jobs fix the issue?
Like this? https://review.opendev.org/726940 Andreas -- Andreas Jaeger aj@suse.com Twitter: jaegerandi SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, D 90409 Nürnberg (HRB 36809, AG Nürnberg) GF: Felix Imendörffer GPG fingerprint = EF18 1673 38C4 A372 86B1 E699 5294 24A3 FF91 2ACB
participants (4)
-
Akihiro Motoki
-
Andreas Jaeger
-
Monty Taylor
-
Radosław Piliszek