From a release point of view this RFE LGTM.

Le lun. 29 mars 2021 à 15:23, Brian Rosmaita <rosmaita.fossdev@gmail.com> a écrit :
On 3/29/21 8:50 AM, Brian Rosmaita wrote:
> Hello Requirements Team,
>
> The Cinder team recently became aware of a potential data-loss bug [0]
> that has been fixed in os-brick master [1] and backported to os-brick
> stable/wallaby [2].  We've proposed a release of os-brick 4.4.0 from
> stable/wallaby [3] and are petitioning for an RFE to include 4.4.0 in
> the wallaby release.

I had a quick discussion with Hervé and he prefers 4.3.1 as the version
number for the new release.  Except for the version number, everything
else in this email still applies.

>
> We have three jobs running tempest with os-brick source in master that
> have passed with [1]: os-brick-src-devstack-plugin-ceph [4],
> os-brick-src-tempest-lvm-lio-barbican [5],and os-brick-src-tempest-nfs
> [6].  The difference between os-brick master (at the time the tests were
> run) and stable/wallaby since the 4.3.0 tag is as follows:
>
> master:
> d4205bd   3 days ago  iSCSI: Fix flushing after multipath cfg change
> (Gorka Eguileor)
> 0e63fe8  2 weeks ago  Merge "RBD: catch read exceptions prior to
> modifying offset" (Zuul)
> 28545c7 4 months ago  RBD: catch read exceptions prior to modifying
> offset (Jon Bernard)
> 99b2c60  2 weeks ago  Merge "Dropping explicit unicode literal" (Zuul)
> 7cfdb76  6 weeks ago  Dropping explicit unicode literal (tushargite96)
> 9afa1a0  3 weeks ago  Add Python3 xena unit tests (OpenStack Release Bot)
> ab57392  3 weeks ago  Update master for stable/wallaby (OpenStack
> Release Bot)
> 91a1cca  3 weeks ago  (tag: 4.3.0) Merge "NVMeOF connector driver
> connection information compatibility fix" (Zuul)
>
> stable/wallaby:
> f86944b   3 days ago  Add release note prelude for os-brick 4.4.0 (Brian
> Rosmaita)
> c70d70b   3 days ago  iSCSI: Fix flushing after multipath cfg change
> (Gorka Eguileor)
> 6649b8d  3 weeks ago  Update TOX_CONSTRAINTS_FILE for stable/wallaby
> (OpenStack Release Bot)
> f3f93dc  3 weeks ago  Update .gitreview for stable/wallaby (OpenStack
> Release Bot)
> 91a1cca  3 weeks ago  (tag: 4.3.0) Merge "NVMeOF connector driver
> connection information compatibility fix" (Zuul)
>
> This gives us very high confidence that the results of the tests run
> against master also apply to stable/wallaby at f86944b.
>
> Thank you for considering this request.
>
> (I've included Nova here because the bug occurs when the configuration
> option that enables multipath connections on a compute is changed while
> volumes are attached, so if this RFE is approved, nova might want to
> raise the minimum version of os-brick in wallaby to 4.4.0.)
>
>
> [0] https://launchpad.net/bugs/1921381
> [1] https://review.opendev.org/c/openstack/os-brick/+/782992
> [2] https://review.opendev.org/c/openstack/os-brick/+/783207
> [3] https://review.opendev.org/c/openstack/releases/+/783641
> [4]
> https://zuul.opendev.org/t/openstack/build/30a103668e4c4a8cb6f1ef907ef3edcb
> [5]
> https://zuul.opendev.org/t/openstack/build/bb11eef737d34c41bb4a52f8433850b0
> [6]
> https://zuul.opendev.org/t/openstack/build/3ad3359ca712432d9ef4261d72c787fa




--
Hervé Beraud
Senior Software Engineer at Red Hat
irc: hberaud
-----BEGIN PGP SIGNATURE-----

wsFcBAABCAAQBQJb4AwCCRAHwXRBNkGNegAALSkQAHrotwCiL3VMwDR0vcja10Q+
Kf31yCutl5bAlS7tOKpPQ9XN4oC0ZSThyNNFVrg8ail0SczHXsC4rOrsPblgGRN+
RQLoCm2eO1AkB0ubCYLaq0XqSaO+Uk81QxAPkyPCEGT6SRxXr2lhADK0T86kBnMP
F8RvGolu3EFjlqCVgeOZaR51PqwUlEhZXZuuNKrWZXg/oRiY4811GmnvzmUhgK5G
5+f8mUg74hfjDbR2VhjTeaLKp0PhskjOIKY3vqHXofLuaqFDD+WrAy/NgDGvN22g
glGfj472T3xyHnUzM8ILgAGSghfzZF5Skj2qEeci9cB6K3Hm3osj+PbvfsXE/7Kw
m/xtm+FjnaywZEv54uCmVIzQsRIm1qJscu20Qw6Q0UiPpDFqD7O6tWSRKdX11UTZ
hwVQTMh9AKQDBEh2W9nnFi9kzSSNu4OQ1dRMcYHWfd9BEkccezxHwUM4Xyov5Fe0
qnbfzTB1tYkjU78loMWFaLa00ftSxP/DtQ//iYVyfVNfcCwfDszXLOqlkvGmY1/Y
F1ON0ONekDZkGJsDoS6QdiUSn8RZ2mHArGEWMV00EV5DCIbCXRvywXV43ckx8Z+3
B8qUJhBqJ8RS2F+vTs3DTaXqcktgJ4UkhYC2c1gImcPRyGrK9VY0sCT+1iA+wp/O
v6rDpkeNksZ9fFSyoY2o
=ECSj
-----END PGP SIGNATURE-----