On 06/09/2025 06:35, Dmitriy Rabotyagov wrote:
I'm frankly not sure about Registered user part.
Because as a contributor, who is working on the patch, I don't want any user to drop WIP label off randomly, while I keep working on it. Or set the label accidentally - then while I'll be waiting for reviews they will never come.
It might be fair to do so for project maintainers, but setting the permission too loose might be not great.
personally i would block the ablity to use the Work in progress state in gerrit entrily and actully enforce our contributors guidance to use workflow -1 for work in progress patches optionally in combination with [WIP] in the commit https://opendev.org/opendev/infra-manual/src/branch/master/doc/source/develo... https://docs.openstack.org/project-team-guide/review-the-openstack-way.html#... in general we have historically discuage using the gerrit native work in progress state after it was added in favor of maintaining our documented convention of usign workflow -1 and or [WIP] in the commit. gerrit is already setup to enforce this properly where the core team and the owner of the patch can set the values. if there is a way to entirely disable setting work in progress via the ACLs that probably a better solution then extending toggle rights to cores as it avoid parallel workflows that deviate from what in our documentation.
On Fri, 5 Sept 2025, 23:31 Goutham Pacha Ravi, <gouthampravi@gmail.com> wrote:
On Fri, Sep 5, 2025 at 6:38 AM Jeremy Stanley <fungi@yuggoth.org> wrote: > > On 2025-09-05 09:33:44 +0200 (+0200), Dmitriy Rabotyagov wrote: > > I think it's only patch owner (or possible Gerrit Admins) who can > > remove WIP status. AFAIK it's not possible for the Core-Reviewers > > group to remove WIP from the patch as of today. > [...] > > With the current state of cinder's ACL[*] that's correct, but it's a > permission that can be delegated easily. It might be a good idea to > grant toggleWipState to the cinder-core group similar to what's done > for neutron[**]. > > [*] https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/... > [**] https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/... > --
Neat suggestion, I've had this issue in the past with manila repos; I think it's worth doing this universally across all openstack repos: https://review.opendev.org/c/openstack/project-config/+/959904
> Jeremy Stanley