On Tue, 2022-05-17 at 20:18 +0200, Radosław Piliszek wrote:
In Nova and Masakari (and Kolla for that matter), the relied upon is the packaged version. Using libvirt from PyPI is simply too much PITA to care about.
we do not depend on libvirt-python in our unti or funtional tests as by design unit and fucnitonal tests should mock external depencices like that. we have libvirt fixutres we use when we need to fake interactions with libvirt. so libvirt-python is very deliberatly not part of nova's requirement.txt or test-requirement.txt its a runtime dep that can be provieed by pypi or the disto but its not managed by upper constraits since its not installed via pypi in our any our tox environments. devstack has the lovely hack https://github.com/openstack/devstack/blob/3155217fb6a14b9c7d9c9a6f1bf11e958... which remvoes libvirt from uc but its actully installed form the disto pacages in our devstack envionments https://github.com/openstack/devstack/blob/3155217fb6a14b9c7d9c9a6f1bf11e958... it proably should be in our bindep.txt https://github.com/openstack/nova/blob/master/bindep.txt or incldued in extras like the other virt dirver libs https://github.com/openstack/nova/blob/master/setup.cfg#L28= but as i said we make sure its not a depency for our tox jobs and its installed by devstack from the disto repos for our integration testing jobs.
Kind regards, -yoctozepto
On Tue, 17 May 2022 at 19:57, Dmitry Tantsur <dtantsur@redhat.com> wrote:
Hi all,
It is happening again, the Bifrost CI is broken because libvirt-python cannot be built from source, this time on Stream 9.
Missing type converters: int *:1 ERROR: failed virDomainQemuMonitorCommandWithFiles
I created a gist with a reproducer: https://gist.github.com/dtantsur/835303c6a68ed77157016f5955183115.
I cannot count how many times we had to deal with similar errors. I assume, libvirt-python has to be newer than the installed Python (8.2.0 in CS9, 8.0.0 in constraints). Should we stop constraining libvirt-python? Any other ideas?
Dmitry
--
Red Hat GmbH, Registered seat: Werner von Siemens Ring 14, D-85630 Grasbrunn, Germany Commercial register: Amtsgericht Muenchen/Munich, HRB 153243, Managing Directors: Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross