On 2025-09-08 12:41:51 +0100 (+0100), Sean Mooney wrote: [...]
personally i would block the ablity to use the Work in progress state in gerrit entrily and actully enforce our contributors guidance to use workflow -1 [...]
The reason OpenDev wanted the WIP toggle (we had our own proof-of-concept implementation back in 2012 which we tried unsuccessfully to get added upstream in Gerrit at the time) is that, being a single state for the change, it can potentially be unset by a different person than the one who originally set it without pushing a new revision (or resorting to getting a Gerrit admin involved). When we gave up, we compromised by replacing the Approved label with a Workflow label that included -1 in the range, but this was only ever intended as a workaround for the lack of an explicit change state. Gerrit upstream was eventually convinced of the use case years later and added a WIP feature, so our hope was that Workflow -1 could eventually be discouraged in favor of that.
gerrit is already setup to enforce this properly where the core team and the owner of the patch can set the values. [...]
Only if the requisite label permissions have been configured in the project's individual Gerrit ACL, similar to what Goutham's change does with toggleWipState. A lot of OpenStack projects have done it (more than have configured toggleWipState), but not all. -- Jeremy Stanley