On 9/4/20 2:44 AM, Herve Beraud wrote:
Hey Oslofolk,
I request an FFE for these oslo.messaging changes [1].
The goal of these changes is to run rabbitmq heartbeat in python thread by default.
Also these changes deprecating this option to prepare future removal and force to always run heartbeat in a python thread whatever the context.
Land these changes during the victoria cycle can help us to prime the option removal during the next cycle.
Thanks for your time,
With the overall non-client library freeze yesterday, this isn't just an Oslo feature freeze request. It is also a release and requirements exception as well. The code change itself is very minor. But this flips a default for a behavior that hasn't been given very wide usage and runtime. I would be very cautious about making a change like that right as we are locking down things and trying to stabilize for the final release. It's a nice change, but personally I would feel more comfortable giving it all of the wallaby development cycle running as the new default to make sure there are no unintended side effects. I am interested in hearing Ben's opinion though. Sean