On 3/22/19 2:45 PM, Matthew Thode wrote:
On 19-03-22 14:40:20, Ben Nemec wrote:
On 3/22/19 2:38 PM, Matthew Thode wrote:
On 19-03-22 14:32:01, Ben Nemec wrote:
Hi,
Our stable/stein patches in oslo.db are currently failing the lower-constraints job due to [0]. I assume master has the same problem since there haven't been any changes since branching. It looks like the problem is that psycopg2 < 2.7 doesn't work with postgresql 10, and we're getting 10 now on bionic.
The simple solution is to bump the lower-constraint, but I'm not sure how that's going to work for the stable branch since we can't change requirements there. How do we proceed?
Thanks.
-Ben
lower-constraints are controlled by each project individually. You can raise the minimum version. If you need to raise upper-constraints as well or add a globally known bad version to global-requirements then there'd need to be change in the requirements repo.
But we can't change lower-constraints without also updating the minimum requirement, which means we can't release the stable branch because it would require a feature release.
There's nothing in the reqs repo that prevents you from updating the minimum in requirements.txt as well (global-requirements does not track versions execpt known bad ones and sometimes a cap). As for requiring a feature release, ya, that could be a problem but the release team would be best to ask about it.
Yeah sorry, I should have been more explicit in my first email. My concern is how to fix this without making the stable branch unreleaseable. I already proposed a patch to bump the version on master, but I don't think it's valid for backport. Maybe I should have tagged stable instead (done).