On Tue, 2023-12-05 at 09:04 +0100, Rodolfo Alonso Hernandez wrote:
Hello Sean:
The bridge name in the port VIF details was added for the VLAN aware VMs feature. [1] is the patch adding this functionality in Nova. This is also used with bridge type ports (for hybrid plug). yes but we then asked for this to always be set so we coudl eventually remove our config options for this. https://github.com/openstack/neutron/commit/995744c576503b1de90c922dbecf690a... https://bugs.launchpad.net/neutron/+bug/1788009
this change is requried to eventualy allow live migration between ml2/ovs and ml2/ovn when using vlan networkign https://lists.openstack.org/pipermail/openstack-dev/2018-August/133546.html i have 0 time to accutually fix all th things to make that work generically sicne that would also like need use to make it work for geneve too.
But there is no requirement to include the name of the OVS bridge in this dictionary and we are not doing that for any other directly attached ports, not in ML2/OVS nor in ML2/OVN. If Nova requires that, then it should be needed to create an RFE in Neutron to always include it. we have discuss this in the past and asked that this alwasy be set for ml2/ovn and any other ml2 driver that manage ovs. if ml2/ovs does not always set it even when trunk port are not used then https://bugs.launchpad.net/neutron/+bug/1788009 hwas been regressed and we shoudl fix that.
Regards.
[1]https://review.opendev.org/c/openstack/nova/+/260700
On Mon, Dec 4, 2023 at 6:55 PM <smooney@redhat.com> wrote:
On Mon, 2023-12-04 at 16:13 +0100, Rodolfo Alonso Hernandez wrote:
Hello Mahudeeswaran:
This topic is being discussed in [1]. The patch [2] you are referring to is not changing the previous code related to the mentioned parameter "bridge name". Please check [3].
Also consider that this value was populated when using Trunk ports, to store the Trunk bridge name created on the port description. In ML2/OVN, all ports are attached to the integration bridge (there is a configuration parameter to define the integration name bridge called "integration_bridge", that by default is "br-int"). just to be clear from a nova perspective i would expect the value to always be populated when ovn binds the prot normally.
nova may have config options for the default bridge name to use but we should not be relying on them. so as apart of the ml2/ovs to ml2/ovn migration the bridge_name in the port binding should get update to the correct value for the current cloud.
we have not formally deprcated https://docs.openstack.org/nova/latest/configuration/config.html#neutron.ovs... but we likely shold do that now that we can rely on neutron ml2 backend that supprot ovs always settign this.
Regards.
[1]
https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack....
[2]
https://github.com/openstack/neutron/commit/569bafbbd5f90a458d781f1e49f099f9...
[3]
https://github.com/openstack/neutron/commit/569bafbbd5f90a458d781f1e49f099f9...
On Mon, Dec 4, 2023 at 3:50 PM Mahudeeswaran Palanisamy <
mahudees@gmail.com>
wrote:
Hi All,
Looks like as part of the below commit, bridge_name info has been removed from port binding vif_details dictionary. Is there any way that we can get the bridge_name info of a port?
As far as checked we can get this info by checking if port UUID is part of the “ports” array in “sudo ovs-vsctl list br” output. But there is no equivalent way to get from Java SDK.
https://github.com/openstack/neutron/commit/569bafbbd5f90a458d781f1e49f099f9...
Thanks, Mahudees