On Wed, Oct 2, 2019 at 11:24 PM Eric Fried <openstack@fried.cc> wrote:
> I'm pretty sure Jay wasn't doing 60% of the reviews in Nova
Clearly not what I was implying.
> splitting out placement was supposed to *reduce* the load on the nova
> core team?
In a sense, that's exactly what I'm suggesting - but it took a couple
releases (those releases) to get there. Both the effort to do the
extraction and the overlap between the placement and nova teams during
that time frame pulled resource away from nova itself.
> If anything that was a time sink that is now finished,
> placement is off soaring on its own merits and we have a bunch of
> resource back as a result, no?
Okay, I can buy that. Care to put a number on it?
> How about approved specs require a majority (or some larger-than-two
> number) of the cores to +2 it to indicate "yes we should do this, and
> yes we should do it this cycle"? Some might argue that this unfairly
> weight efforts that have a lot of cores interested in seeing them land,
> instead of the actual requisite two, but it sounds like that's what
> you're shooting for?
I think the "core sponsor" thing will have this effect: if you can't get
a core to sponsor your blueprint, it's a signal that "we" don't think it
should be done (this cycle).
I like the >2-core idea, though the real difference would be asking for
cores to consider "should we do this *in this cycle*" when they +2 a
spec. Which is good and valid, but (I think) difficult to
explain/track/quantify/validate. And it's asking each core to have some
sense of the "big picture" (understand the scope of all/most of the
candidates) which is very difficult.
> since we've expanded the entire core team to be able to approve specs,
> people that are +2 on a spec should be expected to be willing to help in
> reviewing the resulting blueprint code that comes out of it, but that
> doesn't always happen.
Agree. I considered trying to enforce that spec and/or blueprint
approvers are implicitly signing up to "care about" those
specs/blueprints, but I assumed that would result in a drastic reduction
in willingness to be an approver :P
Actually, that sounds a very reasonable suggestion from Matt.
If you do care reviewing a spec, that also means you do care reviewing the implementation side.
Of course, things can happen meanwhile and you can be dragged on "other stuff" (claim what you want) so you won't have time to commit on the implementation review ASAP, but your interest is still fully there.
On other ways, it's a reasonable assumption to consider that cores approving a spec somehow have the responsibility to move forward with the implementation and can consequently be gently pinged for begging reviews.
Which I suppose would serve to reduce the number of approved blueprints
in the cycle... Hm....
That's just the reflect of the reality IMHO.
efried
.