On Fri, Jan 10, 2020 at 6:12 AM James Page <james.page@canonical.com> wrote:
Hi Stamatis
Thankyou for this work!
I'll take a look at your charm over the next few days.
On Wed, Jan 8, 2020 at 11:25 AM Stamatis Katsaounis < skatsaounis@admin.grnet.gr> wrote:
Hi all,
Purpose of this email is to let you know that we released an unofficial charm of OpenStack Watcher [1]. This charm gave us the opportunity to deploy OpenStack Watcher to our charmed OpenStack deployment.
After seeing value in it, we decided to publish it through GRNET GitHub Organization account for several reasons. First of all, we would love to get feedback on it as it is our first try on creating an OpenStack reactive charm. Secondly, we would be glad to see other OpenStack operators deploy Watcher and share with us knowledge on the project and possible use cases. Finally, it would be ideal to come up with an official OpenStack Watcher charm repository under charmers umbrella. By doing this, another OpenStack project is going to be available not only for Train version but for any future version of OpenStack. Most important, the CI tests are going to ensure that the code is not broken and persuade other operators to use it.
Before closing my email, I would like to give some insight on the architecture of the code base and the deployment process. To begin with, charm-watcher is based on other reactive OpenStack charms. During its deployment Barbican, Designate, Octavia and other charms' code bases were counseled. Furthermore, the structure is the same as any official OpenStack charm, of course without functional tests, which is something we cannot provide.
I'd suggest that we initiate the process to include your watcher charm as part of the OpenStack Charmers project on opendev.org; once the initial migration completes adding some functional tests should be fairly easy as you'll be able to run them on the Canonical 3rd party CI infrastructure.
This requires that a couple of reviews be raised - here are examples for the new Manila Ganesha charms:
https://review.opendev.org/#/c/693463/ https://review.opendev.org/#/c/693462/
One is for the infrastructure setup, the other is to formally include the repositories as part of the TC approved project. If you would like to raise them for the watcher charm I'm happy to review with Frode (who is the current PTL).
Speaking about the deployment process, apart from having a basic charmed OpenStack deployment, operator has to change two tiny configuration options on Nova cloud controller and Cinder. As explained in the Watcher configuration guide, special care has to be done with Oslo notifications for Nova and Cinder [2]. In order to achieve that in charmed OpenStack some issues were met and solved with the following patches [3], [4], [5], [6]. With these patches, operator can set the extra Oslo configuration and this is the only extra configuration needs to take place. Finally, with [7] Keystone charm can accept a relation with Watcher charm instead of ignoring it.
To be able to deploy GRNET Watcher charm on Train, patches [3], [4], [5] and [7] have to be back-ported to stable/19.10 branch but that will require the approval of charmers team. Please let me know if such an option is available and in that case I am going to open the relevant patches. Furthermore, if you think that it could be a good option to create a spec and then introduce an official Watcher charm, I would love to help on that.
I'd rather we wait until the 20.02 charm release - dependent changes have all landed and will be included.
I wish all a happy new year and I am looking forward to your response and
possible feedback.
Happy new year to you as well!
PS. If we could have an Ubuntu package for watcher-dashboard [8] like
octavia-dashboard [9] we would release a charm for it as well.
I'll chat with coreycb and see if we might be able to package that for 20.04/Ussuri.
Hi, I'll take a look at packaging watcher-dashboard. Corey Cheers
James
-- Corey