On Thu, 2024-06-06 at 09:11 -0400, Ihar Hrachyshka wrote:
On Thu, Jun 6, 2024 at 6:46 AM <smooney@redhat.com> wrote:
Thank you Julia, this is very helpful, I wasn't aware. This covers both commits (Git -> Overview) and reviews (Gerrit -> Approvals), it seems. And I am able to add a "project is neutron" filter that aggregates from all project repos too. its missing a breakdown fo how many reviews people are doing
On Wed, 2024-06-05 at 20:48 -0400, Ihar Hrachyshka wrote: the breakdown of +1 -1 +2 -2 and +w and the + to - ratio
when i filetered on nova on the gerrtit tab i didnt see any obvious way to determin that.
When I select Gerrit -> Approvals and then filter by project = neutron, I see +1, -1, +2, -2 listed separately (see screenshot, hopefully it gets through), but yes - no +Ws and no calculation of the ratio (which I'd assume should be relatively easy to calculate.)
[image: image.png] ah its under approves not overview ok that is reasonably workable.
i thin the "approvals" column is actiolly the total number of reviews so that column name should proably be updated. the main use i have of the raitio os to see as a glance which reviews exclivily or almost exlcitlivye leave only +1 reviews. you can infer that form other metirics too. neither all +1 or all -1 are good and a biais in either direction is fine but if we see a lot fo reivew form one perosn or one company that are all +1 espiecally if they dont have any inline comments in the review that a redflag that they are effectively stats gaming. and that there review may not be an indicator of quaility with regards to the relevent patch. you can create some interestign views with the dashboard like https://openstack.biterg.io/app/dashboards?security_tenant=openstack#/view/95487340-6762-11e9-a198-67126215b112?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-90d,to:now))&_a=(description:'Gerrit%20Approvals%20panel%20by%20Bitergia',filters:!(('$state':(store:appState),meta:(alias:Bots,disabled:!f,index:gerrit,key:author_bot,negate:!t,params:(query:!t),type:phrase),query:(match:(author_bot:(query:!t,type:phrase)))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:gerrit,key:project,negate:!f,params:(query:nova),type:phrase),query:(match_phrase:(project:nova))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:gerrit,key:branch,negate:!t,params:(query:master),type:phrase),query:(match_phrase:(branch:master)))),fullScreenMode:!f,options:(darkTheme:!f,hidePanelTitles:!f,useMargins:!t),query:(language:lucene,query:''),timeRestore:!f,title:'Gerrit%20Approvals',viewMode:view) i.e. the peopel who have reviewed changes to nova stable (non master) branches in the last 90 days.
Ihar
On Wed, Jun 5, 2024 at 1:28 PM Julia Kreger <juliaashleykreger@gmail.com
wrote:
Just as a note, I know stackalytics has had issues over the years, in
as an unofficial tool, such that an entirely different dashboard has been posted[0] with the help of the Foundation. At a glance, it doesn't appear to provide review level statistics, but there are also some separate tools to generate that data if needed.
-Julia
[0]: https://openstack.biterg.io/app/dashboards#/view/Overview
On Wed, Jun 5, 2024 at 7:43 AM Ihar Hrachyshka <ihrachys@redhat.com> wrote:
Hi,
I noticed that "neutron" is not an option in the Module list when Commits are selected, and no neutron commits are registered since ~Oct 2023.
On the other hand, other Neutron program repos (e.g. neutron-lib and neutron-tempest-plugin) are available in the list and do register commits.
Also, when Reviews are selected, neutron module is back as an
part option, and
review stats are correctly updated.
I checked governance yaml and it doesn't strike me as incorrect:
https://opendev.org/openstack/governance/src/commit/5f93b99a3c90b452f6c73686...
Any ideas what may have happened?
Thanks, Ihar