On 18-12-11 20:54:03, Matthew Thode wrote:
On 18-12-11 18:37:45, Clark Boylan wrote:
On Tue, Dec 11, 2018, at 6:35 PM, Tony Breeds wrote:
On Tue, Dec 11, 2018 at 05:03:12PM -0600, Ben Nemec wrote:
The tooz gate is currently blocked on https://bugs.launchpad.net/python-tooz/+bug/1808046 which seems to have been introduced with grpcio 1.16.0. I need to raise that issue with the grpc folks, but in the meantime should we block the problematic versions? grpcio isn't currently in g-r and I can't remember what our policy on transitive dependencies is, so I thought I'd solicit opinions.
Yup just add it in this section: http://git.openstack.org/cgit/openstack/requirements/tree/global-requirement...
Do we need to have the constraints generation tooling install tooz[etcd3] so that the transitive dep for grpcio is installed too? Or will that get pulled in because it is in global-requirements?
Enough has changed in how this all works I'm not totally sure what is necessary anymore but tooz lists etcd3 as an extra requires so you have to ask for it to get those deps.
ya, it should be in global-requirements if it's an extra dep, the reason why gating didn't catch it is because it's not checking.
see http://logs.openstack.org/47/624247/3/check/requirements-check/f8b35d2/job-o... for example.
going to see if I can add that...
Ignore this, I thought we were talking about grpcio being in listed as a direct (optional) dependency. Time to go to sleep. -- Matthew Thode