---- On Mon, 15 Jul 2019 19:30:26 +0900 Thierry Carrez <thierry@openstack.org> wrote ----
Ghanshyam Mann wrote:
---- On Sun, 14 Jul 2019 05:38:28 +0900 Sean McGinnis <sean.mcginnis@gmx.com> wrote ----
On Sat, Jul 13, 2019 at 09:19:35PM +0900, Ghanshyam Mann wrote:
---- On Sat, 13 Jul 2019 21:16:32 +0900 Ghanshyam Mann <gmann@ghanshyammann.com> wrote ----
Hi Release team,
Today I noticed while doing patrole review that stable/stain has been created for patrole which is wrong. Patrole is branchless[1] and I remember I have not requested the stable branch while releasing the patrole.
Is it created by mistakenly ? or intentional?
I found the patch which created this - https://review.opendev.org/#/c/650173/1.
Can we revert that but that patch has more changes?
-gmann
We can't really just revert it. If you would like to change this, please update the patrole release type to tempest-plugin or move it to be an independent release deliverable if it is not actually cycle based.
You can also remove the branching information with that change, then after that is gone and there isn't a risk of recreating it, the infra team may be able to assist in deleting the existing branch.
Release model for patrole is 'cycle-with-intermediary' which is right, we do not need to change that. We just need to remove the stable/stein and branch information which was added for the only stein. I will push the change.
Can we have a tag which clearly says the branchless and no-stable branch nature for deliverables?
'tempest-plugins' was introduced for a different purpose. new tag can be applicable for other deliverables also (current or in future). That can help to avoid these errrors.
Creating a new release model or a new deliverable type sounds a bit overkill.
I think the simpler would be to add a new value to the existing "stable-branch-type" key. Like "stable-branch-type: none" and then set that value for all tempest plugins, tempest itself and patrole.
Thanks, that will work perfectly in Tempest, and its plugins cases. -gmann
See https://review.opendev.org/670808 as a strawman.
-- Thierry Carrez (ttx)