On Wed, May 22, 2019 at 08:45:29AM +0200, Dirk Müller wrote:
Hi Tony,
Thanks for the write-up.
2) Switch to the new canonical constraints URL on master
At the last Denver PTG we also discussed the switch from UPPER_CONSTRAINTS_FILE environment variable to TOX_CONSTRAINTS_FILE. As this change and the switch from UPPER_CONSTRAINTS_FILE to TOX_CONSTRAINTS_FILE would touch the very same line of text in the tox.ini, I would suggest that we combine that into one review as that is ~ 300 reviews less to conflict-merge and resolve when both would happen independently at the same time.
I started the patch series to add TOX_CONSTRAINTS_FILE in addition to UPPER_CONSTRAINTS_FILE so that lower-constraints setting looks less odd here:
https://review.opendev.org/657886 https://review.opendev.org/660187
Would be good to get this in in-time so that requirements team can do both changes in one review set.
Yup if they're approved when we start we can do this at the same time. It's just another line in the shell script :) Yours Tony.