---- On Mon, 18 Nov 2024 11:08:23 -0800 Sean Mooney wrote ---
Hi everyone o/
As many will be aware, over the last month or two, I and some others have been looking to help maintain and extend the Watcher project.
At the ptg, I proposed several topics to cover the administrivia of reviving the project. To bring it to a healthy state where features, bugs and general maintenance could be performed on an ongoing basis and avoid its retirement at the end of the 2025.1 cycle.
One of the follow-up items to enable that was the extension of the watcher Gerrit groups to allow others to supplement the largely inactive core groups.
https://etherpad.opendev.org/p/r.79644f8f3cd04686c4f45c10aa35d8ac#L47 https://etherpad.opendev.org/p/r.79644f8f3cd04686c4f45c10aa35d8ac#L47>
To that end, I would like to ask the existing watcher core team and TC (or other community members :) ) to provide input on the following proposal.
0.) I want to state upfront that I do not want to take away review rights or diminish the experience and efforts of any of the past or present members of the watcher team. I am sending this proposal to enable the watcher project to function effectively and I am welcome to feedback or objections.
1.) To facilitate the changes in the rest of the proposal I would like to formally ask to be added to all of the existing watcher Gerrit groups
* watcher-core https://review.opendev.org/admin/groups/77cd139bd57514e98e5e694a82f7e261b474... https://review.opendev.org/admin/groups/77cd139bd57514e98e5e694a82f7e261b4748a8a>
* watcher-release https://review.opendev.org/admin/groups/b265e6b6457de71c7ecfc2a3c70f0c52cde5... https://review.opendev.org/admin/groups/b265e6b6457de71c7ecfc2a3c70f0c52cde577db>
* watcher-dashboard-core https://review.opendev.org/admin/groups/77cd139bd57514e98e5e694a82f7e261b474... https://review.opendev.org/admin/groups/77cd139bd57514e98e5e694a82f7e261b4748a8a>
* watcher-dashboard-release https://review.opendev.org/admin/groups/904be58ec9fa0e811166ce6144d6314cc7b9... https://review.opendev.org/admin/groups/904be58ec9fa0e811166ce6144d6314cc7b9e609>
* watcher-specs-core https://review.opendev.org/admin/groups/747af616eb8748aee5b17d9493f9ebbc49e8... https://review.opendev.org/admin/groups/747af616eb8748aee5b17d9493f9ebbc49e8cf74>
* watcher-tempest-core https://review.opendev.org/admin/groups/09a91d8e24af9ce44b80062c4851a1d2fa3d... https://review.opendev.org/admin/groups/09a91d8e24af9ce44b80062c4851a1d2fa3d4d14>
2.) watcher-release and watcher-dashboard-release
Historically, there has been a benefit to having separate core teams for the master and the stable branches. As the velocity of projects has decreased and projects have become more mature the delineation between the maintainers of the master branch and the stable branches has lessened. I believe there is still merit in having the flexibility to add people directly to the release team independently from the core team so I am not proposing replacing the *-release teams with *-core.
To that end, I would like to make the following changes to the membership of watcher-release and watcher-dashboard-release - add stable-maint to both release groups - add watcher-core to watcher-release, as we have done in other projects the ask to the watcher-core team is, if you do not have time to review stable branches, or do not feel comfortable with applying stable policy, then there is no expectation to review on the stable branches. - add watcher-dashboard-core to watcher-dashboard-release - me (sean-k-mooney as release-liaison) to facilitate backports and release activities and Gerrit membership admin.
3.) watcher-core and watcher-dashboard-core
As it currently stands the core groups are relatively inactive https://tinyurl.com/bdz9k47n
full url: https://openstack.biterg.io/app/dashboards?security_tenant=openstack#/view/95487340-6762-11e9-a198-67126215b112?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-6M%2FM,to:now))&_a=(description:'Gerrit%20Approvals%20panel%20by%20Bitergia',filters:!(('$state':(store:appState),meta:(alias:Bots,disabled:!f,index:gerrit,key:author_bot,negate:!t,params:(query:!t),type:phrase),query:(match:(author_bot:(query:!t,type:phrase)))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:gerrit,key:project,negate:!f,params:(query:watcher),type:phrase),query:(match_phrase:(project:watcher)))),fullScreenMode:!f,options:(darkTheme:!f,hidePanelTitles:!f,useMargins:!t),query:(language:lucene,query:''),timeRestore:!f,title:'Gerrit%20Approvals',viewMode:view https://openstack.biterg.io/app/dashboards?security_tenant=openstack#/view/95487340-6762-11e9-a198-67126215b112?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-6M%2FM,to:now))&_a=(description:'Gerrit%20Approvals%20panel%20by%20Bitergia',filters:!(('$state':(store:appState),meta:(alias:Bots,disabled:!f,index:gerrit,key:author_bot,negate:!t,params:(query:!t),type:phrase),query:(match:(author_bot:(query:!t,type:phrase)))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:gerrit,key:project,negate:!f,params:(query:watcher),type:phrase),query:(match_phrase:(project:watcher)))),fullScreenMode:!f,options:(darkTheme:!f,hidePanelTitles:!f,useMargins:!t),query:(language:lucene,query:''),timeRestore:!f,title:'Gerrit%20Approvals',viewMode:view>)
Dan Smith and Slawek Kaplonski were added to help with the retirement/gate issues on behalf of the TC While Dan has offered to help bootstrap the core team we need to be cognizant that both Dan and Slawek have other commitments. Chenker has previously expressed that they intend to review when time allows but they have limited time to do so.
To that end, I would like to propose that I be added to both core teams, To have a health core team we will eventually need to have at least 3 active reviewers. Watcher will still be 1-2 reviews short of that, but I hope that can be addressed over the coming months.
As others become active over the 2025.1 cycles I would like to revisit the membership and extend the core team after milestone 2 or more realistically after milestone 3 if others demonstrate interest and capacity to review.
4.) watcher-tempest-core
This is a newly created group added by https://review.opendev.org/c/openstack/project-config/+/934357 https://review.opendev.org/c/openstack/project-config/+/934357> This group intends to allow the review team for the tempest plugin to diverge from the main watcher core group.
To enable effective review and maintenance of the tempest plugin I would like to propose the following membership changes.
- tempest-core should be added as a fallback, to guide best practices, and review if they have time. - gmann has volunteered to help with this too so I propose they be added as a direct member - I would like to be added to have a second active reviewer available. Note, while I can provide some review input I have less knowledge of tempest in general as such I will rely on Gmann's guidance in this area.
5.) watcher-specs
Several years ago Nova expanded the nova-specs core group to include nova-core there were a number of motivating factors but one of them was the large overlap between the two groups. another factor was the role of a spec core (focusing on the design constraints, upgrade impact, API impact ectra) is different from the implementation considerations(testing, code quality, performance) often the line between the two is subtle and blurred.
To that end, I would like to propose the following changes. - first, I would like to be directly added to the specs core group - second, I would like to add the watcher-core group to watcher-specs.
If this proposal is accepted I would like to try and move forward with this in the next week or so to unblock the pending review backlog.
++ Agree with the plan; let's wait this week to hear Chenker's feedback and if they can make the required changes. We have already passed the m-1 of this release cycle and should not delay it more. -gmann
Regards sean
PS many of the open reviews are cleanup i have submitted so this does not directly address review bandwidth for my personal patches but i think it still has value in general.