On Fri, 2019-01-25 at 17:09 +0000, Sean Mooney wrote:
On Fri, 2019-01-25 at 16:55 +0000, Stephen Finucane wrote:
Happy Friday,
Just a quick heads up that the upcoming release of git-review, likely 2.0, removes a feature. Currently, git-review will detect the presence of "bug", "lp", "blueprint" or "bp" in commit messages and, if found, set the Gerrit topic for that submitted review to something based on the blueprint/bug.
As noted in the commit that removed this [1], this hadn't been updated to support StoryBoard and there was no desire to do so given the OpenStack-specific nature of this feature along with the fact that it often did the wrong thing.
We (being the people who authored and reviewed the patch) think this is definitely a good thing to do, but if anyone has genuine concerns about the removal of this functionality, be sure to raise them here or on #openstack-infra before we push that release out next week. does it strill automatically set the topic to the current git branch name? i never really use the feature that is being remvoed but i always use the reverse. e.g. create a branch with the correct name and rely on git review setting the gerrit topic to match.
No, this feature continues to work as is, and as always can be disabled with the '-T'/'--no-topic' flags. Stephen
Cheers, Stephen
[1] https://github.com/openstack-infra/git-review/commit/03768832c4