in general, i tend to think that adding more tooling to help the code become more consistent is a good thing for the community and especially people who are new to a project. there is one point i'd like to mention in response to something that Clint said. On Thu, Apr 18, 2019 at 3:10 PM Clint Byrum <clint@fewbar.com> wrote:
I just wanted to add that I have been using black for some internal projects, and it is an absolute joy to forget about code formatting. This is different than the pep8 checks. The git hook just does it, and our CI confirms that you do it, and there's no more "oops I forgot pep8".
i think having this be automated is something that throws my personal workflow off, and i hope that if it does become enshrined as a commit hook that we give developers the tooling to test locally before pushing for review. i like to be able to test all my changes locally before i push for review, if there is a tool in between me and the review and that changes my code then i /definitely/ want to be able to test these changes before i go to review. i imagine this is not a big deal, others have mentioned adding a tox target or similar. i just wanted to bring it up as a point to consider in this process. peace o/