which adds an interface to a router and expects the response parameter 'tenant_id' to be in the response.
I looked for recently merged changes that could have possibly changed the router API response and it might be something similar to this change:
So I've been going through the neutron code trying to convert everything to use project_id this cycle when I found some TODOs from 12 years ago on removing tenant_id :-/
I tried to make sure we continue to accept tenant_id, but I guess in this case I also removed it from the response. Although I have canary patches in some of the networking repos I didn't have one for the SDK, I'll add it to my list going forward.
but I don't really understand if/how that could change the API.
My guess is it's because of this part of the change:
https://review.opendev.org/c/openstack/neutron/+/972982/14/neutron/db/ db_base_plugin_common.py
I'm not sure what the desired fix will be here, whether the API should be more backward compatible and/or if the openstacksdk test should be fixed by s/tenant_id/project_id/ or something else.
Please hold your rechecks if CI has failed on your patch due to this.
I've pushed a change to fix it as I think it's time to move forward:
https://review.opendev.org/c/openstack/openstacksdk/+/976008
Thanks melwitt, Brian. I will leave the API change decision to the neutron team, but this brought up a testing gap in our gate. I remember the past discussion about testing the sdk cross services and I added it in the integrated gate testing templates[1], but it seems Neutron does not run the tempest-defined integrated-gate-networking. I remember that concern was the duplicate testing of grenade jobs (by grenade base jobs defined in integrated-gate-networking and neutron grenade jobs). To solve that, I proposed to remove the grenade base jobs from integrated-gate-networking template and adding this template in neutron gate. This will help to detect these failures in advance. Please check if it makes sense. - https://review.opendev.org/c/openstack/tempest/+/976203 - https://review.opendev.org/c/openstack/neutron/+/976204 [1] https://review.opendev.org/c/openstack/tempest/+/801920 -gmaan
If anyone thinks otherwise please let me know.
Thanks for the report and sorry about the breakage,
-Brian
[1] https://github.com/openstack/openstacksdk/ blob/7afe210333ec236a14fc5fa2d4a589e481a43745/openstack/tests/ functional/cloud/test_router.py#L205