On 04/11/2025 18:39, Sean Mooney wrote:
this is not the first chagne for this issue however this is the first oen to potitally be mergable
https://review.opendev.org/c/openstack/nova/+/940135 was you previosu patch that broke ovs.
your new patch is correct and only enables if for vif-type=tap which is correct
https://review.opendev.org/c/openstack/nova/+/960284/3/nova/virt/libvirt/vif...
is there a reason you did not update your previous patch https://review.opendev.org/c/openstack/nova/+/940135 ?
oh sorry you were a review on the other patch not the authour it makes sense why you create your onw patch.
ill see if i cna review it properly. we generally prefer pings for review on irc rather then the mailing list but if its been up for a hwile with no
reviwe this is ok.
On 04/11/2025 16:34, Nell Jerram wrote:
I apologise if this is the wrong place to ask, but is there something I can do to encourage review and approval for https://review.opendev.org/c/openstack/nova/+/960284 ?
Many thanks - Nell