I've set up a local reproducer and tested the latest version of [1]. I also added functional[2] tests with redis and redis sentinel which pass now. Unfortunately we can't easily enable SSL in functional tests (because of the work required in pifpaf) we don't have coverage for SSL scenarios now. However I believe we can move this forward based on my local testing (please try it in your env as well if possible).
[1] https://review.opendev.org/c/openstack/oslo.cache/+/907336 [2] https://review.opendev.org/c/openstack/oslo.cache/+/907651
My proposal also fixes several problems identified in the existing redis backend with keeping consistency between redis backend and redis sentinel backend, which I believe is better.
I also noticed we have a few other libraries with redis support but these have similar problems (and a few more additional problems). I've also pushed patches to address these.
I've captured all of the patches related to redis and redis sentinel in the following etherpad and wonder if we can try merging these all before feature freeze to keep consistent implementation level across all libraries. https://etherpad.opendev.org/p/oslo-redis-sentinel-caracal
Thank you, Takashi Kajinami irc: tkajinam
On 2/2/24 00:39, Sven Kieske wrote:
Hi Daniel,
thanks for the reminder! Do you think it's possible that we can merge any of the two approaches currently being developed in oslo.cache[1][2] for redis sentinel support before the feature freeze?
There are multiple people interested in this feature.
See also our (https://scs.community/) downstream issue tracker:
https://github.com/SovereignCloudStack/issues/issues/489
we are interested in this because we want to provide TLS encrypted caching backends in Openstack and the only good way to currently support this seems to be redis via sentinel, to also provide HA.
We are also working on integrating this in the kolla-ansible deployment project[3].
Thanks for your feedback!