Thanks Jeremy and Hervé!
@Jeremy, @Hervé: I've checked and found two open patches, out of which I was able to abandon one, and asked the owner on the other patch to abandon it. So the listed branches can be deleted *except* one: openstack/os-collect-config
So in my opinion there's no need for further coordination with the teams, as these branches are tagged ocata-eol already.
And thanks Hervé for the script, it helped a lot so far, already
:) + thanks Jeremy for the pointers!
Előd
Le mar. 26 janv. 2021 à 18:35, Jeremy Stanley <fungi@yuggoth.org> a écrit :
On 2021-01-26 17:52:07 +0100 (+0100), Előd Illés wrote:
[...]
> 1. I've used the list_eol_stale_branches.sh [2] script to get the list of
> such not-yet-deleted branches for Ocata [3]. They are all tagged with
> 'ocata-eol', but stable/ocata branch still exists for them. Could you please
> delete these? [3]
I'm happy to, have you made sure any open reviews for those branches
are abandoned first? Gerrit won't allow deletion of a branch with
open reviews.
I think we need a first round of inspection on these stale branches to see if opened patches exist and then if needed start discussion with teams to ask them to drop the patches those who have been found.
I'll try to add this feature to check for opened patches within `list_eol_stale_branches.sh`.
> 2. On the Release Team meeting [1] we were hinted that with the newer
> version of gerrit (that was installed at the end of November) some
> automation is possible through gerrit API in the future. Can I get some help
> about where should I start with the automation? Which repository should I
> look, where can the deletion being triggered ("similarly like branch
> creation")?
[...]
The Gerrit REST API method for deleting branches is documented here:
https://review.opendev.org/Documentation/rest-api-projects.html#delete-branch
I'm not immediately sure where branch creation happens in the forest
of our release automation, but I would expect deletion could be
implemented similarly. Hopefully someone more intimately familiar
with those jobs can chime in.
The access control we'll need to grant to automation so that it can
call that is documented here:
https://review.opendev.org/Documentation/access-control.html#category_delete
It'll need to be added manually as a permission for the Release
Managers group in our All-Projects global ACL which individual
projects inherit, and this documentation updated accordingly:
https://opendev.org/opendev/system-config/src/branch/master/doc/source/gerrit.rst
Happy to answer other questions as they arise.
--
Jeremy Stanley
--
Hervé BeraudSenior Software Engineer at Red Hatirc: hberaud-----BEGIN PGP SIGNATURE-----
wsFcBAABCAAQBQJb4AwCCRAHwXRBNkGNegAALSkQAHrotwCiL3VMwDR0vcja10Q+
Kf31yCutl5bAlS7tOKpPQ9XN4oC0ZSThyNNFVrg8ail0SczHXsC4rOrsPblgGRN+
RQLoCm2eO1AkB0ubCYLaq0XqSaO+Uk81QxAPkyPCEGT6SRxXr2lhADK0T86kBnMP
F8RvGolu3EFjlqCVgeOZaR51PqwUlEhZXZuuNKrWZXg/oRiY4811GmnvzmUhgK5G
5+f8mUg74hfjDbR2VhjTeaLKp0PhskjOIKY3vqHXofLuaqFDD+WrAy/NgDGvN22g
glGfj472T3xyHnUzM8ILgAGSghfzZF5Skj2qEeci9cB6K3Hm3osj+PbvfsXE/7Kw
m/xtm+FjnaywZEv54uCmVIzQsRIm1qJscu20Qw6Q0UiPpDFqD7O6tWSRKdX11UTZ
hwVQTMh9AKQDBEh2W9nnFi9kzSSNu4OQ1dRMcYHWfd9BEkccezxHwUM4Xyov5Fe0
qnbfzTB1tYkjU78loMWFaLa00ftSxP/DtQ//iYVyfVNfcCwfDszXLOqlkvGmY1/Y
F1ON0ONekDZkGJsDoS6QdiUSn8RZ2mHArGEWMV00EV5DCIbCXRvywXV43ckx8Z+3
B8qUJhBqJ8RS2F+vTs3DTaXqcktgJ4UkhYC2c1gImcPRyGrK9VY0sCT+1iA+wp/O
v6rDpkeNksZ9fFSyoY2o
=ECSj
-----END PGP SIGNATURE-----