On Thu, Nov 26, 2020 at 17:45 Jeremy Stanley wrote:
On 2020-11-26 17:30:12 +0000 (+0000), Tristan Cacqueray wrote: [...]
It should do that already, though I haven't tested it with real data. I guess the next step would be to enable such plugin on review-dev.
Well, review-dev hasn't been kept consistent with production and we were planning to decommission it entirely in the coming days along with the temporary review-test we used to run through various upgrade scenarios to get timing data.
Probably the easiest solution will be for one of OpenDev's Zuul admins to arrange an autohold for a build which includes your new plugin, and then we can demo it there before releasing it again (three cheers for "testing like production!"). -- Jeremy Stanley
Well there are some unit tests too here: https://softwarefactory-project.io/cgit/software-factory/re-gerrit/tree/test... And I made sure the table looks similar to the previous implementation. It's quite a simple plugin and I don't expect it to be able to cause problem. Though I'd be happy to get a test instance and feed it with real ci comments to demonstrate the results. -Tristan