On Wed, 2024-03-06 at 13:51 +0900, Takashi Kajinami wrote:
Hello,
Please be aware that LegacyEngineFacade in the latest oslo db release for caracal no longer enables autocommit[1]. Removal was attempted in the previous release, as part of the overall efforts to adapt to sqlalchemy 2.0, but later reverted[2] because multiple projects need more time to adapt to the change. Now the removal is again proposed for caracal and the version currently listed in upper constraints no longer provides that functionality.
Quickly searching the current usage by hound, it seems the project listed in this mail title still contains autocommit=True in LegacyEngineFacade, and is likely broken by the change. I'd suggest checking CI status to evaluate the impact.
Note 1: The list may be incomplete Note 2: It seems aodh is not actually relying on autocommit and the removal might not be affecting it
[1] https://review.opendev.org/c/openstack/oslo.db/+/875986 [2] https://review.opendev.org/c/openstack/oslo.db/+/895631
Thank you, Takashi
Looks like the observability folks have merged my Aodh fix \o/ The only other outstanding project that I'm aware of is Manila. carloss and gouthamr are working on the fix for this, to the best of my knowledge. Cheers, Stephen