On Jul 17, Vivek Pandey <Vivek.Pandey11@ibm.com> wrote:
Hi Joe/ Brian,
Since we didn’t get a chance to discuss the patch [IBM SVf driver] Adding support for callhome plugin, we can continue the conversation here. Patch : https://review.opendev.org/c/openstack/cinder/+/951829.
We need callhome enabled as default for which we have introduced a parameter “callhome” in cinder.conf. This feature is to fecth the os_version, cinder-manage version and ispbhaenabled.
Note: We are not fetching any customer’s sensitive data.
Please let me know if you’ve had a chance to review NetApp’s ActiveIQ implementation. Netapp’s ActiveIQ code ref : https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/netapp...
As we have discussed during the 9th July cinder call, Anoop from NetApp confirmed that they are enabling it by default and EMS details are being captured from the logs. Based on that, do you think we can align or extend our current IBM callhome implementation (from the patch above) to follow a similar approach?
I think this question would benefit from a wider audience. As I said in the code review [1], I don't think our drivers should have default enabled phone-home functionality in the upstream repository. A vendor is certainly free to change this in a packaged version, but I think our defaults confer information about how we think about our users and I tend to want to put them first. I'm happy to hear other opinions on this. I did bring this up with the TC on IRC when it came up, it may be that we have a better consensus on such things across projects. I'm eager to hear other thoughts. 1. https://review.opendev.org/c/openstack/cinder/+/951829/comment/c6b5df57_4086... -- Jon