I thought the 09 Feb 2021 review jam was highly valuable.
Without the discussions we had, I think the "Secure RBAC" patch set would be unapproachable for me. For example, having knowledge of the (new) oslo-policy features that the patches make use of seems to be a requirement for deeply understanding the changes. As a direct result of the review jam [0], I feel that I have enough understanding and comfortability to make valuable review feedback on these patches.
[0] and also having read/reviewed the secure-rbac spec previously, to be fair
On Fri, Feb 5, 2021 at 7:10 AM Julia Kreger juliaashleykreger@gmail.com wrote:
In the Ironic team's recent mid-cycle call, we discussed the need to return to occasionally having review jams in order to help streamline the review process. In other words, get eyes on a change in parallel and be able to discuss the change. The goal is to help get people on the same page in terms of what and why. Be on hand to answer questions or back-fill context. This is to hopefully avoid the more iterative back and forth nature of code review, which can draw out a long chain of patches. As always, the goal is not perfection, but forward movement especially for complex changes.
We've established two time windows that will hopefully not to be too hard for some contributors to make it to. It doesn't need to be everyone, but it would help for at least some people whom actively review or want to actively participate in reviewing, or whom are even interested in a feature to join us for our meeting.
I've added an entry on to our wiki page to cover this, with the current agenda and anticipated review jam topic schedule. The tl;dr is we will use meetpad[1] and meet on Mondays at 2 PM UTC and Tuesdays at 6 PM UTC. The hope is to to enable some overlap of reviewers. If people are interested in other times, please bring this up in the weekly meeting or on the mailing list.
I'm not sending out calendar invites for this. Yet. :)
See everyone next week!
-Julia