On Tue, 2020-09-15 at 11:03 -0500, Sean McGinnis wrote:
> > I would like to ask for FFE for the RFE "allow replacing the QoS
> > policy of bound port", [1].
> > This feature adds the extra step to port update operation to change
> > the allocation in Placement to the min_kbps values of the new QoS
> > policy, if the port has a QoS policy with minimum_bandwidth rule and
> > is bound and used by a server.
> >
> > In neutron there's one open patch:
> > https://review.opendev.org/747774
> >
> > There's an open bug report for the neutron-lib side:
> > https://bugs.launchpad.net/neutron/+bug/1894825 (placement story:
> > https://storyboard.openstack.org/#!/story/2008111 )  and a fix for that:
> > https://review.opendev.org/750349
> >
> > [1] https://bugs.launchpad.net/neutron/+bug/1882804
> >
>
> Since this requires an update to neutron-lib, adding [requirements] to
> the subject. Non-client library freeze was two weeks ago now, so it's a
> bit late.
so this is a new feature right.
this is not a bug fix so this also need a neutron feature freeze exception.

i have not reviewd the patch yet but didnt we agree to now allow modifyign existign rules in place
os i assume the replacemnt this enables is changign form one qos rule set to another.

looking at the neutorn patch this seams incomplte and only allows modifying the placment allocation i
a limited edgecase, mainly when teh prot was orginally booted with a qos policy.
as written i dont think https://review.opendev.org/#/c/747774/18 should be merged.
im reviewing it now.


>
> The fix looks fairly minor, but I don't know that code. Can you comment
> on the potential risks of this change? We should be stabilizing as much
> as possible at this point as we approach the final victoria release date.
>
> Sean
>
>
>