The first one of those was trivial (although I am confused as to why it didn't fail for the test run where the patch was proposed, I can't see an obvious race condition). I have proposed a fix at https://review.openstack.org/#/c/621346/ . Michael On Sat, Dec 1, 2018 at 8:30 AM Matt Riedemann <mriedemos@gmail.com> wrote:
Just FYI there are a couple of regressions hitting nova unit and functional test jobs right now:
https://bugs.launchpad.net/nova/+bug/1806123
^ Is likely due to mocking a global for the new I/O concurrency semaphore stuff in the libvirt driver. I'm not sure what we should do about that one. During the code review I suggested writing a fixture which would essentially maintain the context manager (so we have __enter__ and __exit__) but just make it a noop, but we still want to make sure it's called in places where it's used.
https://bugs.launchpad.net/nova/+bug/1806126
^ Is a bit hairier since I'm seeing both weird, potentially global mock, failures and also timeouts, also potentially because of mocking globals. Since there is no functional code change tied to that one yet (it's still being reviewed, this was a recreate test change only), I have proposed a revert to try and stem the bleeding unless someone (mdbooth?) can root cause and fix it faster.
Happy rechecking!
--
Thanks,
Matt