On Mon, Mar 29, 2021 at 8:09 PM Jeremy Stanley <fungi@yuggoth.org> wrote:
On 2021-03-29 19:47:24 -0400 (-0400), Peter Matulis wrote:
I changed the testenv to 'pdf-docs' and the build is still being skipped.
Do I need to submit a PR to have this [1] set to 'false'?
[1]:
https://opendev.org/openstack/openstack-zuul-jobs/src/commit/01746b6df094c25... [...]
Oh, yep that'll need to be adjusted or overridden as well. I see that https://review.opendev.org/678077 explicitly chose not to do PDF builds for deploy guides for the original PDF docs implementation a couple of years ago. Unfortunately the commit message doesn't say why, but maybe this is a good opportunity to start.
Any other thoughts before I propose a change to the below? https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/j... However, many (most?) API projects seem to include their
deployment guides in their software Git repos, so switching this on for everyone might break their deploy guide builds. If we combine it with an expectation for a deploy-guide-specific PDF building tox testenv like you had previously, then it would get safely skipped by any projects without that testenv defined. -- Jeremy Stanley