Hey Jay, Apologies for the late reply, we've already discussed this in private, but I really want to show my full support for what I truly believe is a great way to improve the Ironic community. Thank you for taking the lead on the change, hope will see that effective soon! Ciao Riccardo On Tue, Oct 15, 2024 at 2:00 PM Doug Goldstein <cardoe@cardoe.com> wrote:
Hello Jay,
I think this is a great approach to on-boarding new folks by having the tiered approach. Thank you for taking the time to propose it and do the work necessary to make it happen.
Additionally I’m honored to be considered by the Ironic project and I would happily accept becoming a reviewer.
Thank you. -- Doug
On Oct 10, 2024, at 10:04 AM, Jay Faulkner <jay@gr-oss.io> wrote:
OpenStack & Ironic community,
Ironic has not added a core reviewer in years. We've had new contributors during this time, but none who has, as yet, risen to the level of being given core review access -- which reflects how steep the learning/responsibility curve is to being a core on an OpenStack project.
I'd like to propose, on behalf of many Ironic cores and our PTL Riccardo, a new core review structure for Ironic projects. The goal being to provide an on-ramp for newer cores into the community.
The existing ironic-core group will be removed and replaced with two new groups: - ironic-reviewers will contain contributors permitted to perform core reviews (+2/-2) against patches in ironic projects. This group will be initially populated with two new code reviewers (should they accept), CID and cardoe. - ironic-approvers will contain contributors permitted to both perform core reviews and workflow (+A) patchsets. This group will be initially populated with the existing membership of ironic-core.
I hope that by providing a middle point on the route to being an approver, we'll be able to extend trust to new contributors more quickly and give them incentive to code review more often -- since their reviews will be able to have a positive impact on landing code more quickly.
I've proposed a change here: https://review.opendev.org/c/openstack/project-config/+/931991 which makes the first step in adjusting ACLs to split the groups. I've also as part of this change unified more ironic-related projects under the ironic core review banner after auditing those core groups and seeing some inactive contributors in them.
Ironic cores have already discussed this privately, and we have a lazy consensus to perform this change. This email serves as both notice to the larger community and as a formal way to gain consensus. If there are any questions or concerns please let us know.
Thanks, Jay Faulkner