On 1/30/25 08:09, Sean Mooney wrote:
>
> On 30/01/2025 10:07, Herve Beraud wrote:
>> Hey folks,
>>
>> I observed that oslo.vmware has not received any significant
>> modifications since almost 4 years ago [1].
>> The only changes proposed to oslo.vmware since a while are just
>> related to infra changes (python versions, tox versions, etc...).
>>
>> Due to the recent news about vmware [2], I wonder if oslo.vmware is
>> still a relevant library in our context and I wonder if it is worth
>> spending time on maintaining it.
>
> we still have the vmware driver in nova and oslo.vmware is an optional
> dependency for that
>
> https://github.com/openstack/nova/blob/master/setup.cfg#L36
>
> SAP expressed interest in maintaining the vmware integration 2? cycles
> ago maybe 3 and
>
> have been running a third party ci and trying to fix issues in nova/
> neutron as they arise
>
> so we cant deprecate or retire it until we do the same for the code that
> uses it.
>
> we have tried to avoid the term deprecated with the vmware driver in nova.
>
> we consider it "experimental" perhaps is a better term.
>
> its in a similar state to linux bridge in neutron.
>
> it "should" mostly work but its still not properly maintained/tested to
> a point where
> i would recommend new usage of it. for existing deployments however we
> have not proposed removing it
> in 2025.1
>
> we may want to discuss that again but i would not expect it to be
> removed in the next cycle or two.

It is timely this comes up because literally yesterday I ran into the
situation where I had to manually install oslo.vmware into my unit test
tox venv in order to run unrelated unit tests. (I was having problems
with dependency installs for an older branch and ended up installing
requirements.txt and test-requirements.txt content manually):

[...]

Failed to import test module: nova.tests.unit.virt.vmwareapi.test_images
Traceback (most recent call last):
   File "/usr/lib64/python3.6/unittest/loader.py", line 428, in
_find_test_path
     module = self._get_module_from_name(name)
   File "/usr/lib64/python3.6/unittest/loader.py", line 369, in
_get_module_from_name
     __import__(name)
   File
"/home/fedora/openstack-nova/nova/tests/unit/virt/vmwareapi/test_images.py",
line 24, in <module>
     from oslo_vmware import rw_handles
ModuleNotFoundError: No module named 'oslo_vmware'

Failed to import test module:
nova.tests.unit.virt.vmwareapi.test_network_util
Traceback (most recent call last):
   File "/usr/lib64/python3.6/unittest/loader.py", line 428, in
_find_test_path
     module = self._get_module_from_name(name)
   File "/usr/lib64/python3.6/unittest/loader.py", line 369, in
_get_module_from_name
     __import__(name)
   File
"/home/fedora/openstack-nova/nova/tests/unit/virt/vmwareapi/test_network_util.py",
line 20, in <module>
     from oslo_vmware import vim_util
ModuleNotFoundError: No module named 'oslo_vmware'

[...]

So yeah, at best it might be a possibility that we move the oslo.vmware
requirement from global-requirements.txt to Nova requirements.txt or
test-requirements.txt if it's not used more widely. But the library
itself has to stay as long as the VMware driver does.

-melwitt