Hey Sorin,

I'm glad to see you are excited as we are about this effort! Since you are one of the core developers of Molecule, I was hoping to get some of your insight on the work we have started in that regard. I have a few patches up for adding in Molecule tests to tripleo-common. At a later point in time, we can discuss the transition of moving all of the Ansible content into the tripleo-ansible repository.

https://review.opendev.org/#/c/662803/
https://review.opendev.org/#/c/662577/

The first is to add the common files that will be used across most, if not all, of the Molecule tests in this repository. The second patch is where I actually implement Molecule tests and symlinks to those common files in the first patch. I wanted to get your thoughts on a few things.

1. How would we hook in the Molecule tests into tox so that it will be tested by CI? Do you have an example of this already being done? I believe from previous discussions you have already added a few Molecule tests to a TripleO repository before. Kevin also had a good ideal of creating an isolated Zuul job so that can be something we can investigate as well.
2. How should we handle the actual tests? In the second patch, I used the playbook.yaml to write the test in a playbook format (the actual test happens during the post_tasks phase). I have always done Molecule testing this way to keep things simple. However, would you recommend that we use the Python testinfra library instead to make sure that certain things exist?

Thanks for any input you may have!

Luke Short, RHCE
Software Engineer, OpenStack Deployment Framework
Red Hat, Inc.


On Mon, Jun 3, 2019 at 2:29 PM Sorin Sbarnea <ssbarnea@redhat.com> wrote:
I am really happy to hear about that as this could be much more effective than having an uncontrollable number of roles scattered across lots of repositories which usually do not play very nice with each other.

I hope that testing these roles using molecule (official ansible testing platform) is also part of this plan.

Cheers
Sorin

On 3 Jun 2019, at 18:42, Kevin Carter <kecarter@redhat.com> wrote:

On Mon, Jun 3, 2019 at 12:08 PM Mohammed Naser <mnaser@vexxhost.com> wrote:
On Mon, Jun 3, 2019 at 12:55 PM Kevin Carter <kecarter@redhat.com> wrote:
>
> Hello Stackers,
>
> I wanted to follow up on this post from last year, pick up from where it left off, and bring together a squad to get things moving.
>
> > http://lists.openstack.org/pipermail/openstack-dev/2018-August/133801.html
>
> The effort to convert tripleo Puppet and heat templates with embedded Ansible to a more consumable set of playbooks and roles is in full effect. As we're working through this effort we believe co-locating all of the Ansible tasks/roles/libraries/plugins throughout the code base into a single purpose-built repository will assist us in streamlining and simplifying. Structurally, at this time, most of tripleo will remain the same. However, the inclusion of tripleo-Ansible will allow us to create more focused solutions which are independently testable, much easier understand, and simple to include into the current heat template deployment methodologies. While a straight port of the existing Ansible tasks will not be entirely possible, the goal of this ongoing effort will be zero impact on our existing workflow and solutions.
>
> To reigniting this effort, I've put up a review to create a new "transformation" squad[0] geared toward building the structure around tripleo-ansible[1] and converting our current solutions into roles/playbooks/libraries/plugins. Initially, we'll be focused on our existing code base; however, long term, I believe it makes sense for this squad to work across projects to breakdown deployment barriers for folks using similar technologies.

+1

> We're excited to get this effort rolling again and would love to work with anyone and everyone throughout the community. If folks are interested in this effort, please let us know.

Most definitely in.  We've had great success working with the TripleO team on
integrating the Tempest role and on the OSA side, we'd be more than happy
to help try and converge our roles to maintain them together.

++
 
If there's any meetings or anything that will be scheduled, I'd be
happy to attend.

 
its still very early but I expect to begin regular meetings (even if they're just impromptu IRC conversations to begin with) to work out what needs to be done and where we can begin collaborating with other folks. As soon as we have more I'll be sure to reach out here and on IRC.
 
> [0] - https://review.opendev.org/662763
> [1] - https://opendev.org/openstack/tripleo-ansible
> --
>
> Kevin Carter
> IRC: cloudnull



-- 
Mohammed Naser — vexxhost
-----------------------------------------------------
D. 514-316-8872
D. 800-910-1726 ext. 200
E. mnaser@vexxhost.com
W. http://vexxhost.com