I have posted a comment on the said patch but I prefer using pyvers in that specific patch because; - The change seems to be a backport candidate and using pyvers helps us backport the change to older branches like Train which still supports python 2 IIRC. - We still use pyvers in the other modules so it would make sense to have consistent implementation before we actually remove usage of pyvers from all modules. Personally I prefer keeping pyvers because it doesn't make much effort but helps us just in case we have Python4 in a future (though I don't know when it really comes) or any distro changes package name format from python3- to python- or any different style. On Sat, Feb 27, 2021 at 9:59 PM Thomas Goirand <zigo@debian.org> wrote:
On 2/27/21 11:28 AM, Radosław Piliszek wrote:
Hi Zigo,
On Sat, Feb 27, 2021 at 10:24 AM Thomas Goirand <zigo@debian.org> wrote:
Using the ${pyvers} so we can switch be between Python versions made sense 1 or 2 years ago. However, I'm in the opinion that we should stop using that, and switch to using python3 everywhere directly whenever possible. Though Tobias seems to not agree (see [1]), so I'm raising the topic in the list so we can discuss this together.
[1] https://review.opendev.org/c/openstack/puppet-swift/+/777564
I had a quick look and I believe Tobias is not against not using that var but the fact that you renamed the resource from python-ceilometermiddleware to ceilometermiddleware which does not make sense indeed and could be breaking.
Kind regards,
-yoctozepto
I'll fix that. But the question remain: shall we deprecate the use of ${pyvers} and use python3 instead?
Cheers,
Thomas Goirand (zigo)