<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Oct 30, 2013 at 9:31 AM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Wed, Oct 30, 2013 at 10:08:03AM +1100, Tom Fifield wrote:<br>
> Hi all,<br>
><br>
> Recently, I did something crazy and got into the "top 10" reviewers<br>
> for OpenStack in a 30/60 day window. Admittedly, this was for<br>
> documentation - which is quite a bit different than code - but the<br>
> experience did give me a small window of insight into the challenge<br>
> faced by our venerable core reviewers. It's a really tough job!<br>
><br>
> One of the aspects that I noticed in doing so many reviews is that a<br>
> review was much easier to perform if another reviewer had been<br>
> through it beforehand. That is, a patch had gone through a couple of<br>
> -1 iterations to finally get a +1 before I saw it.<br>
><br>
> This made me think a little about how much emphasis we place as a<br>
> community on +2 reviews. It can seem at times like they're the only<br>
> reviews we care about. Hell, I've even heard song lyrics from a<br>
> community member that imply this :D<br>
><br>
> I think it's time to bend that focus slightly, and promote the role<br>
> of the +1 reviewers. Every review that a non-core reviewer does<br>
> helps reduce the burden of core reviewers just that little bit.<br>
<br>
</div>It absolutely does, and is much appreciated by us core team<br>
members.<br>
<div class="im"><br>
> Do you see this too? How can we help encourage more +1 reviews?<br>
<br></div></blockquote><div><br></div><div><br></div><div>Perhaps we should try making the top non-core reviewers more visible. Maybe list and thank the top x non-core reviewers and companies in the weekly OpenStack newsletter?</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
</div>It is a tough question. You don't want to put up strict rules since that<br>
is typically counterproductive. Perhaps the biggest carrot to encourage<br>
more +1 reviews, is that it is a stepping stone to becoming a core team<br>
member. eg if you find yourself in the top-10 reviewers on nova for an<br>
extended period of time you'll likely get an invitation to become a<br>
core team member from Russell.<br>
<br>
Looking at our wiki page<br>
<br>
<a href="https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer" target="_blank">https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer</a><br>
<br>
it is very much focused around that idea that you have to write code or<br>
do code fixes to become involved. It isn't really mentioning contribution<br>
via reviews at all. It merely mentions "learn gerrit" and use it to sign<br>
the CLA.<br>
<br>
Similarly this page<br>
<br>
<a href="https://wiki.openstack.org/wiki/Gerrit_Workflow" target="_blank">https://wiki.openstack.org/wiki/Gerrit_Workflow</a><br>
<br>
only mentions review in the context of what happens to *your* patch.<br>
<br>
I think that both those pages could be extended/re-written to strongly<br>
encourage contributors to participate in reviewing other people's patches.<br></blockquote><div><br></div><div>++</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
The "How to Contribute" page should explicitly list "reviewing code<br>
changes" as a primary way to contribute, and mention that it is one<br>
way to get on a path towards gaining the reputation needed to become<br>
a core team reviewer/member.<br>
<br></blockquote><div><br></div><div><br></div><div>++</div><div><br></div><div>Currently the limiting factor in our workflow is reviewers, not patches or patch authors.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The "Gerrit Workflow" page should say something like<br>
<br>
"While you are waiting for review feedback on changes you have<br>
submitted, you should browser other pending changes and provide<br>
review on them. By helping out with other reviews you will be<br>
decreasing the time delay for your own change to receive feedback"<br>
<span class="HOEnZb"><font color="#888888"><br>
Daniel<br>
--<br>
|: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
Mailing list: <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack</a><br>
Post to : <a href="mailto:openstack@lists.openstack.org">openstack@lists.openstack.org</a><br>
Unsubscribe : <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack</a><br>
</div></div></blockquote></div><br></div></div>