<span style="border-collapse:collapse;color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px"><div><div>Hi All,</div></div><div><br></div><div>I would like to propose a minimum required code coverage level per file in Nova. Say 80%. This would mean that any new feature/file should only be accepted if it has over 80% code coverage. Exceptions to this rule would be allowed for code that is covered by skipped tests (as long as 80% is reached when the tests are not skipped).</div>
<div><br></div><div>With 193 python files in nova/tests, Nova unit tests produce 85% overall code coverage (calculated with ./run_test.sh -c [1]). But 23% of files (125 files) have lower then 80% code coverage (30 tests skipped on my machine). Getting all files to hit the 80% code coverage mark should be one of the goals for Folsom.</div>
<div><br></div><div>Some files with low coverage:</div><div><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">nova/flags 18%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">
</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">nova/tests/integrated/test_servers 27%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">
</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">nova/testing/runner 31%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">
</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">nova/api/ec2/faults 36%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">
</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">nova/network/quantum/client 36%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">
</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">nova/network/quantum/melange_connection 38%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">
nova/openstack/common/iniparser 40%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">nova/openstack/common/cfg 41%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">
nova/tests/db/fakes 41%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">nova/console/api 44%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">
nova/image/s3 50%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">nova/api/ec2/__init__ 53%</p><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 16px/normal Georgia">
nova/notifier/log_notifier 56%</p><p></p><p></p><p></p><p></p><p></p><p></p></div><div><br></div><div>best,</div><div>Joe Gordon</div>
<div><br></div><div><br></div><div><br></div>[1] With <a href="https://review.openstack.org/#/c/6750/" style="color:rgb(17,85,204)" target="_blank">https://review.openstack.org/#/c/6750/</a></span>