Is this is really a problem that needs solving? I'd like to believe that no member of Nova Core would approve something that they aren't familiar with.<br><br>IMHO, we should be making better attempts at not letting branches sit around for days/weeks at a time.<br>
<br><div class="gmail_quote">On Mon, Mar 12, 2012 at 4:59 PM, Joe Gordon <span dir="ltr"><<a href="mailto:jogo@cloudscaling.com">jogo@cloudscaling.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi All,<div><br></div><div>I have noticed that some Gerrit branches get approved very quickly, sometimes in a matter of minutes. While most of the time these branches are vetted properly, the window for reviewing can be so small that a non-trivial branch lands but without enough vetting. If someone is in a meeting for half on hour they may miss the entire review window. To fix this problem I propose a minimum time frame (should be overridable in an emergency) for a branch to be approved, perhaps 2 hours. This time frame would start on 'Upload time.' </div>
<div><br></div><div>best,</div><div>Joe Gordon</div><div>
</div>
<br>_______________________________________________<br>
Mailing list: <a href="https://launchpad.net/%7Eopenstack" target="_blank">https://launchpad.net/~openstack</a><br>
Post to : <a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a><br>
Unsubscribe : <a href="https://launchpad.net/%7Eopenstack" target="_blank">https://launchpad.net/~openstack</a><br>
More help : <a href="https://help.launchpad.net/ListHelp" target="_blank">https://help.launchpad.net/ListHelp</a><br>
<br></blockquote></div><br>