<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
Okay just to make things clear...<br>
<div><br>
</div>
<div>Totally agree with everything you said. I don't think we should just put the functionality in core. The safest thing to do is to put it in a separate extension rather than modifying the existing management extension. The safest thing to do is also
to move the functionality to a separate URI space as well. If you do all of this you will have no chance of breaking clients or of running into future conflicts.</div>
<div><br>
</div>
<div>I'm glad to see you protecting the contract :-)</div>
<div><br>
</div>
<div>Having said all of that. This *particular* change is not likely to break folks because it introduces new functionality rather than changing existing functionality and I don't think that conflicts with DELETE token are very likely.</div>
<div><br>
</div>
<div>-jOrGe W.</div>
<div><br>
</div>
<div><br>
<div>
<div>On Jan 26, 2012, at 5:29 PM, Ziad Sawalha wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; ">
<div>A) It sounds like yore making an assumption about what the type of client is. Some clients use WADL to generate stubs or validate contracts. Consider clients like JAX-RS/CXF clients? If you change the WADL, you've changed the contract. Like I said, I think
this would be an edge case, but a key reason we offer API contracts is to allow for predictability from the client side. You break that is you change then contract.</div>
<div><br>
</div>
<div>B) No, the HTTP call would not change. An alternative would be for us to add this to OS-KSVALIDATE which we just shipped. The call would then be:</div>
<div><br>
</div>
<div>DELETE /OS-KSVALIDATE/token</div>
<div>X-Auth_token: …</div>
<div>X-Subject-Token: {token_id}</div>
<div><br>
</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Dolph Mathews <<a href="mailto:dolph.mathews@gmail.com">dolph.mathews@gmail.com</a>><br>
<span style="font-weight:bold">Date: </span>Thu, 26 Jan 2012 17:17:12 -0600<br>
<span style="font-weight:bold">To: </span>Ziad Sawalha <<a href="mailto:ziad.sawalha@rackspace.com">ziad.sawalha@rackspace.com</a>><br>
<span style="font-weight:bold">Cc: </span>Jorge Williams <<a href="mailto:jorge.williams@rackspace.com">jorge.williams@rackspace.com</a>>, Dolph Mathews <<a href="mailto:dolph.mathews@gmail.com">dolph.mathews@gmail.com</a>>, "Yee, Guang" <<a href="mailto:guang.yee@hp.com">guang.yee@hp.com</a>>,
"<a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a>(<a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a>)" <<a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [Openstack] Keystone: is revoke token API "officially" supported<br>
</div>
<div><br>
</div>
<div>
<div bgcolor="#FFFFFF">
<div>A) This wasn't documented at all (AFAIK), so there's no concern of breaking contracts.</div>
<div><br>
</div>
<div>B) Even if it's moved to an extension, would the call change from it's current form?:</div>
<div><br>
</div>
<div> DELETE /tokens/{token_id}</div>
<div><span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); "><br>
</span></div>
<div><span class="Apple-style-span" style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.292969); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469);">I'm not sure what the extension
convention is here.</span></div>
<div><br>
-Dolph Mathews</div>
<div><br>
On Jan 26, 2012, at 4:39 PM, Ziad Sawalha <<a href="mailto:ziad.sawalha@rackspace.com">ziad.sawalha@rackspace.com</a>> wrote:<br>
<br>
</div>
<div></div>
<blockquote type="cite">
<div>
<div>If a client has bound to the contract XSD, they will break if we add this, won't they?</div>
<div><br>
</div>
<div>But… I don't know how many clients would have bound to the OS-KSADM contracts. We've been diligent and strict about not changing the core contract, but this is the first time we've been presented with a change to an extension like this.</div>
<div><br>
</div>
<div>I'd still lean towards the "correct" practice of adding this as another extension. Especially since that extension would only be adding a new method on an existing resource, so would not require complex naming changes…</div>
<div><br>
</div>
<div>Open to alternative points of view..</div>
<div><br>
</div>
<div>Z</div>
<div><br>
</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Jorge Williams <<a href="mailto:jorge.williams@rackspace.com">jorge.williams@rackspace.com</a>><br>
<span style="font-weight:bold">Date: </span>Thu, 26 Jan 2012 13:36:13 -0600<br>
<span style="font-weight:bold">To: </span>Dolph Mathews <<a href="mailto:dolph.mathews@gmail.com">dolph.mathews@gmail.com</a>><br>
<span style="font-weight:bold">Cc: </span>"Yee, Guang" <<a href="mailto:guang.yee@hp.com">guang.yee@hp.com</a>>, "<a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a> (<a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a>)"
<<a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a>>, Ziad Sawalha <<a href="mailto:ziad.sawalha@rackspace.com">ziad.sawalha@rackspace.com</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [Openstack] Keystone: is revoke token API "officially" supported<br>
</div>
<div><br>
</div>
<div>
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
Moving it to an extension makes sense to me. Ziad, does it make sense to add it to OS-KSADM...or is this a different extension all together...revoke token extension?
<div><br>
</div>
<div>-jOrGe W.</div>
<div>
<div><br>
</div>
<div>
<div>
<div>On Jan 26, 2012, at 11:43 AM, Dolph Mathews wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">It is definitely not a documented call (hence the "should this be removed?" comment in the implementation); if it were to be "promoted" from undocumented to an extension, I imagine it would belong in OS-KSADM.
<div><br>
</div>
<div>- Dolph<br>
<br>
<div class="gmail_quote">On Thu, Jan 26, 2012 at 10:51 AM, Yee, Guang <span dir="ltr">
<<a href="mailto:guang.yee@hp.com">guang.yee@hp.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" type="cite">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<div class="MsoNormal">I see it implemented in the code as<u></u><u></u></div>
<div class="MsoNormal"><u></u> <u></u></div>
<div class="MsoNormal">DELETE /v2.0/tokens/{tokenId}<u></u><u></u></div>
<div class="MsoNormal"><u></u> <u></u></div>
<div class="MsoNormal">But it doesn’t appear to be documented in any of the WADLs.<u></u><u></u></div>
<div class="MsoNormal"><u></u> <u></u></div>
<div class="MsoNormal"><u></u> <u></u></div>
<div class="MsoNormal">Thanks!<span class="HOEnZb"><font color="#888888"><u></u><u></u></font></span></div>
<span class="HOEnZb"><font color="#888888">
<div class="MsoNormal"><u></u> <u></u></div>
<div class="MsoNormal">Guang<u></u><u></u></div>
<div class="MsoNormal"><u></u> <u></u></div>
</font></span></div>
</div>
<br>
_______________________________________________<br>
Mailing list: <a href="https://launchpad.net/~openstack" target="_blank">https://launchpad.net/~openstack</a><br>
Post to : <a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a><br>
Unsubscribe : <a href="https://launchpad.net/~openstack" target="_blank">https://launchpad.net/~openstack</a><br>
More help : <a href="https://help.launchpad.net/ListHelp" target="_blank">https://help.launchpad.net/ListHelp</a><br>
<br>
</blockquote>
</div>
<br>
</div>
_______________________________________________<br>
Mailing list: <a href="https://launchpad.net/~openstack">https://launchpad.net/~openstack</a><br>
Post to : <a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a><br>
Unsubscribe : <a href="https://launchpad.net/~openstack">https://launchpad.net/~openstack</a><br>
More help : <a href="https://help.launchpad.net/ListHelp">https://help.launchpad.net/ListHelp</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</span></div>
</blockquote>
</div>
</div>
</span></div>
</blockquote>
</div>
<br>
</div>
</body>
</html>