<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal>As of the following changeset, Nova trunk is completely
broken on Python 2.6. I presume that we’re still supporting
2.6? (We better had be!)<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><span style='font-family:Consolas'>commit
035b43b1fd320008234e066e30629fb0e359b424<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'>Author: Naveed Massjouni
<naveedm9@gmail.com><o:p></o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'>Date: Thu Jan
12 18:38:21 2012 +0000<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'>
Refactoring logging _log function.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'> We
should not be overriding private functions of core python modules.<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'> Fixes
bug: 915597<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'>
Change-Id: I1d1f6dc142cd822030a671f7f2f477a44acafe46<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-family:Consolas'><o:p> </o:p></span></p>
<p class=MsoNormal>The problem is that the code calls super(NovaLogger, self),
but NovaLogger inherits from logging.Logger which is a basic-style class on
Python 2.6, and so you can’t call super on it.<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>I mainly raise this on the mailing list because I thought
that we might want to revert this for now, in case things get a bit
flaming-torches-and-pitchforks. I can propose one of a few fixes (or
someone can beat me to it):<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>1. Remove all the calls to super, replacing them with
explicitly named calls to logging.Logger.<o:p></o:p></p>
<p class=MsoNormal>2. Declare NovaLogger as class NovaLogger(logging.Logger, object),
which I’ve not tried but I which presume works.<o:p></o:p></p>
<p class=MsoNormal>3. As 2, but conditional on Python 2.6.<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Any preferences?<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>While I’m here, any chance we can have a unit test
running on Python 2.6?<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Cheers,<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>Ewan.<o:p></o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
</div>
</body>
</html>