<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" id="owaParaStyle"></style>
</head>
<body fpstyle="1" ocsi="0">
<div style="direction: ltr;font-family: Courier New;color: #000000;font-size: 10pt;">
Yup, if you look at
<div><a href="http://www.darksecretsoftware.com/static/hubcap.html" target="_blank">http://www.darksecretsoftware.com/static/hubcap.html</a></div>
<div>you'll see there's a slot there for core & non-core approvals. We get the core approvers from the repos teams. </div>
<div><br>
</div>
<div>I like the idea of another keyword than !lgtm for cores to say "I approve, but don't consider this the +2" ... perhaps just "lgtm" (no !) heh</div>
<div><br>
</div>
<div>-S</div>
<div><br>
</div>
<div>PS> Notice the funky new stylings thanks to Jake Dahn!</div>
<div><br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF137612" style="direction: ltr; "><font face="Tahoma" size="2" color="#000000"><b>From:</b> Josh Kearney [josh@jk0.org]<br>
<b>Sent:</b> Wednesday, September 07, 2011 12:05 PM<br>
<b>To:</b> Soren Hansen<br>
<b>Cc:</b> Sandy Walsh; openstack@lists.launchpad.net<br>
<b>Subject:</b> Re: [Openstack] A possible alternative to Gerrit ...<br>
</font><br>
</div>
<div></div>
<div>
<div class="gmail_quote">On Wed, Sep 7, 2011 at 6:54 AM, Soren Hansen <span dir="ltr">
<<a href="mailto:soren@linux2go.dk" target="_blank">soren@linux2go.dk</a>></span> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
The critical point has never been whether we could reliably detect<br>
people's votes (even though I really dislike parsing free-form text to<br>
extract critical information like this). Even though Launchpad offers<br>
voting information in a structured manner, we *intentionally* don't<br>
auto-approve things there as soon as they have +2. </blockquote>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<br>
Sometimes there are simply reasons why things shouldn't get merged<br>
even though they have two approves. If there's already one +1, but<br>
someone specific (someone with domain specific knowledge, a release<br>
team member, etc) needs to sign off on it as well, I still want to be<br>
able to say that I've reviewed it and approve of it, without causing<br>
it to get merged. We also want to be able to review features and vote<br>
on them even during freeze times without causing them to get merged.<br>
</blockquote>
<div><br>
Couldn't we just add an extra keyword like '!approved' that Hubcap would only acknowledge from Core members? Unless that keyword is present, no matter how many '!lgtm's are there, Hubcap will not attempt a merge.<br>
</div>
</div>
<br>
</div>
</div>
</div>
</div>
<style type="text/css">embed[type*="application/x-shockwave-flash"],embed[src*=".swf"],object[type*="application/x-shockwave-flash"],object[codetype*="application/x-shockwave-flash"],object[src*=".swf"],object[codebase*="swflash.cab"],object[classid*="D27CDB6E-AE6D-11cf-96B8-444553540000"],object[classid*="d27cdb6e-ae6d-11cf-96b8-444553540000"],object[classid*="D27CDB6E-AE6D-11cf-96B8-444553540000"]{ display: none !important;}</style><style type="text/css">embed[type*="application/x-shockwave-flash"],embed[src*=".swf"],object[type*="application/x-shockwave-flash"],object[codetype*="application/x-shockwave-flash"],object[src*=".swf"],object[codebase*="swflash.cab"],object[classid*="D27CDB6E-AE6D-11cf-96B8-444553540000"],object[classid*="d27cdb6e-ae6d-11cf-96b8-444553540000"],object[classid*="D27CDB6E-AE6D-11cf-96B8-444553540000"]{ display: none !important;}</style>
<font face="monospace">This email may include confidential information. If you received it in error, please delete it.</font></body>
</html>