I have series of commits that can be applied separately and can be treated as separate improvements in my branch.<div>That commits were there before I knew that I should install Gerrit hook.</div><div>Now I have bunch of commits without Change-Id while commit --amend works only with the last one. How can I edit previous commits?<br clear="all">
<br><div>Kind regards, Yuriy.</div><br>
<br><br><div class="gmail_quote">On Thu, Aug 4, 2011 at 20:41, Brad Hall <span dir="ltr"><<a href="mailto:brad@nicira.com">brad@nicira.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I'm not sure about during an interactive rebase .. I've always just<br>
done the amend before or after the rebase and the changeid will get<br>
added if it isn't already there.<br>
<br>
Thanks,<br>
<font color="#888888">Brad<br>
</font><div><div></div><div class="h5"><br>
On Thu, Aug 4, 2011 at 9:16 AM, Trey Morris <<a href="mailto:trey.morris@rackspace.com">trey.morris@rackspace.com</a>> wrote:<br>
> I had to register my git email with gerrit as well, no problems after.<br>
> If you do a "git commit --amend" will the hook add the change-id after you<br>
> edit the commit message? I ask because it didn't when doing an interactive<br>
> rebase. I did it this morning but I pasted the change-id in myself.<br>
> -trey<br>
><br>
> On Thu, Aug 4, 2011 at 10:40 AM, Brad Hall <<a href="mailto:brad@nicira.com">brad@nicira.com</a>> wrote:<br>
>><br>
>> If your commit doesn't have a change-id message you can add one by<br>
>> amending the commit (git commit --amend) as long as you have the<br>
>> commit-msg hook in place and executable. (See here for more details:<br>
>> <a href="http://wiki.openstack.org/GerritWorkflow" target="_blank">http://wiki.openstack.org/GerritWorkflow</a>) This page doesn't mention<br>
>> it but you need to chmod +x the hook if it isn't already.<br>
>><br>
>> Thanks,<br>
>> Brad<br>
>><br>
>> On Thu, Aug 4, 2011 at 2:44 AM, Yuriy Taraday <<a href="mailto:yorik.sar@gmail.com">yorik.sar@gmail.com</a>> wrote:<br>
>> > Thanks to he fix, "invalid author" problem vanished.<br>
>> > Now I'm getting "missing Change-Id in commit message" error.<br>
>> > What is the best way to provide Change-Id to existing commits?<br>
>> ><br>
>> > Kind regards, Yuriy.<br>
>> ><br>
>> ><br>
>> > On Wed, Aug 3, 2011 at 18:58, James E. Blair <<a href="mailto:corvus@inaugust.com">corvus@inaugust.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> Yuriy Taraday <<a href="mailto:yorik.sar@gmail.com">yorik.sar@gmail.com</a>> writes:<br>
>> >><br>
>> >> > Hello.<br>
>> >> ><br>
>> >> > I'm trying to use Gerrit to propose changes to Keystone.<br>
>> >> > I'm using instructions from <a href="http://wiki.openstack.org/GerritWorkflow" target="_blank">http://wiki.openstack.org/GerritWorkflow</a><br>
>> >> > to<br>
>> >> > push<br>
>> >> > my changes.<br>
>> >> > I'm getting "invalid author" error but my settings/contacts page<br>
>> >> > looks<br>
>> >> > fine<br>
>> >> > and the e-mail listed there and in the error message are the same.<br>
>> >> > What could go wrong?<br>
>> >><br>
>> >> Hi,<br>
>> >><br>
>> >> I don't think you did anything wrong. It looks like we made a mistake<br>
>> >> in importing account information from Launchpad.<br>
>> >><br>
>> >> We try to import as much account information (name, ssh keys, email<br>
>> >> addresses, etc.) from Launchpad as possible. It looks like the email<br>
>> >> address needs to be added to more than one location in the database.<br>
>> >><br>
>> >> I believe I have fixed up your entry by hand (feel free to email me or<br>
>> >> find me on IRC (jeblair)) if you still have problems. I'll work on<br>
>> >> updating our import script to fix the rest of the accounts and send out<br>
>> >> another email to this list when that is complete.<br>
>> >><br>
>> >> Thanks for helping us test this!<br>
>> >><br>
>> >> -Jim<br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > Mailing list: <a href="https://launchpad.net/~openstack" target="_blank">https://launchpad.net/~openstack</a><br>
>> > Post to : <a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a><br>
>> > Unsubscribe : <a href="https://launchpad.net/~openstack" target="_blank">https://launchpad.net/~openstack</a><br>
>> > More help : <a href="https://help.launchpad.net/ListHelp" target="_blank">https://help.launchpad.net/ListHelp</a><br>
>> ><br>
>> ><br>
>><br>
>> _______________________________________________<br>
>> Mailing list: <a href="https://launchpad.net/~openstack" target="_blank">https://launchpad.net/~openstack</a><br>
>> Post to : <a href="mailto:openstack@lists.launchpad.net">openstack@lists.launchpad.net</a><br>
>> Unsubscribe : <a href="https://launchpad.net/~openstack" target="_blank">https://launchpad.net/~openstack</a><br>
>> More help : <a href="https://help.launchpad.net/ListHelp" target="_blank">https://help.launchpad.net/ListHelp</a><br>
><br>
><br>
</div></div></blockquote></div><br></div>