<div dir="ltr">Hi <span style="font-family:arial,sans-serif;font-size:13px">Ihar, </span><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">I had directly approved those patches as they were just reviewed and merged into master (they were also pretty trivial bugs imo). I'll wait for another +2 though in the future. </span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px"><br>Best, </span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">Aaron </span></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 22, 2014 at 10:07 AM, Ihar Hrachyshka <span dir="ltr"><<a href="mailto:ihrachys@redhat.com" target="_blank">ihrachys@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA512<br>
<br>
</div>I didn't really want to call out any names, but since you ask, those<br>
patches are here:<br>
<br>
- - <a href="https://review.openstack.org/#/c/108534/" target="_blank">https://review.openstack.org/#/c/108534/</a><br>
- - <a href="https://review.openstack.org/#/c/108533/" target="_blank">https://review.openstack.org/#/c/108533/</a><br>
- - <a href="https://review.openstack.org/#/c/106199/" target="_blank">https://review.openstack.org/#/c/106199/</a><br>
<br>
Probably other patches of the same author are of the same nature.<br>
<br>
/Ihar<br>
<div class=""><br>
On 22/07/14 18:28, Gary Kotton wrote:<br>
> Which patch was this?<br>
><br>
> On 7/22/14, 2:37 PM, "Ihar Hrachyshka" <<a href="mailto:ihrachys@redhat.com">ihrachys@redhat.com</a>><br>
> wrote:<br>
><br>
</div><div class="">> Hi, I'm walking thru the list of stable backports for Neutron, and<br>
> I've found an instance when a patch was pushed to gate by its<br>
> author (or better, backporter) without receiving any feedback from<br>
> other team members.<br>
><br>
> Let me remind you that (quoting [1]):<br>
><br>
> "Each backported commit proposed to gerrit should be reviewed and<br>
> +2ed by two stable-maint members before it is approved. Where a<br>
> stable-maint member has backported a fix, a single other +2 is<br>
> sufficient for approval."<br>
><br>
> So please refrain from pushing patches before another maintainer<br>
> checks your backport. Without following that rule, we miss<br>
> opportunity for peer review.<br>
><br>
> [1]: <a href="https://wiki.openstack.org/wiki/StableBranch#Gerrit" target="_blank">https://wiki.openstack.org/wiki/StableBranch#Gerrit</a><br>
><br>
> Cheers, /Ihar<br>
>><br>
</div><div class="">>> _______________________________________________<br>
>> Openstack-stable-maint mailing list<br>
>> <a href="mailto:Openstack-stable-maint@lists.openstack.org">Openstack-stable-maint@lists.openstack.org</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint</a><br>
><br>
</div><div class="">-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)<br>
Comment: Using GnuPG with Thunderbird - <a href="http://www.enigmail.net/" target="_blank">http://www.enigmail.net/</a><br>
<br>
</div>iQEcBAEBCgAGBQJTzpo5AAoJEC5aWaUY1u57ZAEH/i3GTKkt7y4CvhmcAxvMUvJd<br>
ldm4ewrriTfFbsptvZzRSHMzdE6U+XBKS19NXmWZ8EjgGisNIKSxZSTA07JNsUUa<br>
er+rPYLUNZhyiQQ/0hUrksYEmyyILnzBA+Q3S7GMEejwUz2k58/t8QjRmXDv8sUT<br>
XEZ/Yv6GF0ggHtrTT2DkBWuz+UmgIWSQGXNEuYgjSNLKfSRaSebhuJ+1cV4/ypx9<br>
8KUn2EfAy1+WVdbVVCq7X0t17zbtX+ciz/BDJjyNNuhQmqXPMldbCcDIYA4aEK0u<br>
dM0RBsCZLH2UorUrUcxlePGRHTSlITN7ho//ASaP7Byz57xi0F0SbGEzcBYrMD0=<br>
=3osn<br>
<div class="HOEnZb"><div class="h5">-----END PGP SIGNATURE-----<br>
<br>
_______________________________________________<br>
Openstack-stable-maint mailing list<br>
<a href="mailto:Openstack-stable-maint@lists.openstack.org">Openstack-stable-maint@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint</a><br>
</div></div></blockquote></div><br></div>